Benchmarking JSON reader for compressed inputs #17219
Open
+47
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
3 tasks
shrshi
added
non-breaking
vuule
reviewed
Nov 7, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
Fixes #17068 Fixes #12299 This PR introduces a new datasource for compressed inputs which enables batching and byte range reading of multi-source JSONL files using the reallocate-and-retry policy. Moreover. instead of using a 4:1 compression ratio heuristic, the device buffer size is estimated accurately for GZIP, ZIP, and SNAPPY compression types. For remaining types, the files are first decompressed then batched. ~~TODO: Reuse existing JSON tests but with an additional compression parameter to verify correctness.~~ ~~Handled by #17219, which implements compressed JSON writer required for the above test.~~ Multi-source compressed input tests added! Authors: - Shruti Shivakumar (https://github.com/shrshi) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Karthikeyan (https://github.com/karthikeyann) URL: #17161
mhaseeb123
reviewed
Nov 19, 2024
mythrocks
reviewed
Nov 19, 2024
vuule
approved these changes
Nov 19, 2024
mhaseeb123
reviewed
Nov 19, 2024
mhaseeb123
reviewed
Nov 19, 2024
karthikeyann
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #17161 for implementations of compression and decompression functions (
io/comp/comp.cu,io/comp/comp.hpp,io/comp/io_uncomp.hppandio/comp/uncomp.cpp)Depends on #17323 for compressed JSON writer implementation.
Adds benchmark to measure performance of the JSON reader for compressed inputs.
Checklist