Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCAN_DATE filter documentation is unclear #256

Closed
nbirnel opened this issue Dec 7, 2016 · 0 comments
Closed

SCAN_DATE filter documentation is unclear #256

nbirnel opened this issue Dec 7, 2016 · 0 comments

Comments

@nbirnel
Copy link
Contributor

nbirnel commented Dec 7, 2016

The current comments specify using FixNum for "day arguments". It is easy to read EARLIER_THAN as a "date argument". (At least one person other than myself did so https://community.rapid7.com/thread/7672). I suggest specifying exactly which arguments take FixNum.

The ScanDate::FORMAT value spec is difficult to understand without scrolling down to it's implementation. I suggest specifying how to use it.

PR will follow momentarily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nbirnel