-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Example Scripts #244
Comments
This is on my perpetual "to do" list. I'll see if I can get them updated soon. I just need to set aside some time for it. |
Great, I'm looking forward to it! Thanks! |
Updating (at least) one of these, since one allegedly does exactly what I nee for a particular task, but I have a question. Perhaps it's just a style difference? In the For some reason, the script as it is in the repo doesn't loop through all of my sites, and/or all of my scan engines the way I would expect. The line in question tosses an engine ID of -1, then only displays the average for the local scan engine. P.S. Assuming I can get things working, and can stay in the same style lane as you guys, I'd be happy to submit a pull request, if it'll save you some time. |
@d4t4king the difference is performing one API request before the loop vs performing an API request on each iteration of the loop (i.e. n engines would be n API requests). It's mostly a performance thing. It may take longer to send many requests than it would to get all of the data in a single request up front. With a few engines it won't be noticeable, but when you have hundreds of engines it would slow down the script. I suppose it could be made more readable or maybe it just needs a comment to explain it. |
Going forward completed, task-oriented example scripts should be moved over to https://github.com/rapid7/nexpose-resources (This is mostly a note to myself) |
Will the example scripts be updated to work with the new update?
The text was updated successfully, but these errors were encountered: