Add the ability to use numerics with info command #14053
Conversation
| unless mod && mod.respond_to?(:fullname) | ||
| print_error("Invalid module index: #{mod_name}") | ||
| return false | ||
| end |
There was a problem hiding this comment.
Before
Before when an invalid number was used with the use command it didn't return anything
After
Now when an invalid number is used with the use command it will return [-] Invalid module index: 99999
There was a problem hiding this comment.
what happens if you do info on an invalid number/multiple invalid numbers?
There was a problem hiding this comment.
@dwelch-r7, you beat me on this: #14053 (comment)
There was a problem hiding this comment.
Sorry forgot to add this in!
When an invalid number is used with the info command it will return [-] Invalid module index: 9999
| @@ -110,6 +110,22 @@ def cmd_info_help | |||
| print_line | |||
| end | |||
|
|
|||
| def print_module(mod, dump_json: false, show_doc: false) | |||
There was a problem hiding this comment.
Think I'd prefer this to be called something like print_info thoughts?
There was a problem hiding this comment.
I wasn't sure what to call it as I'm not used to naming conventions yet, so If you think print_info would be better I can change that.
| args.each { |name| | ||
| # Use a module by search index | ||
| index_from_list(@module_search_results, mod_name) do |mod| | ||
| next unless mod && mod.respond_to?(:fullname) |
There was a problem hiding this comment.
Just wondering if we could have the same error message that has been added to the use command when an index is invalid?
There was a problem hiding this comment.
Oh, sorry, I didn't see it happens later, when checking the return value of framework.modules.create(name).
cgranleese-r7
force-pushed
the
accepting-numerics-for-info-command
branch
from
769977c
to
e094a55
Compare
Release NotesImproved the |
Before
Before you were not able to use numerics with the info command
After
Now if you use a numeric with the info command it will display the corresponding modules info
Verification
List the steps needed to make sure this thing works
msfconsolesearch winrminfo 0info 9999999returns[-] Invalid module: 9999999