Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "label" support to sessions #8425

Open
OJ opened this issue May 21, 2017 · 4 comments
Open

Add "label" support to sessions #8425

OJ opened this issue May 21, 2017 · 4 comments

Comments

@OJ
Copy link
Contributor

OJ commented May 21, 2017

Sessions are currently identifiable by ip, machine name and user context when viewed from the sessions list. It'd be fantastic to have the ability to add some kind of label to the session to make it more identifiable. For example. if I pop SYSTEM on a CFO's desktop, I don't have the ability to know that it's the CFO's desktop from looking at the session list. I'd like to be able to do something like this:

meterpreter> sessions -i 3 -label CFO-DESKTOP

Then when I run sessions -x I can see the label that I have applied. It'd be nice to also be able to switch sessions based on this tag as well (using sessions CFO-DESKTOP for example).

Thoughts on this? I'm happy to implement it myself. If people would see this as useful, would it require storing in the DB metadata alongside the rest of the session information?

@OJ OJ added the enhancement label May 21, 2017
@OJ OJ self-assigned this May 21, 2017
@OJ OJ added the library label May 21, 2017
@busterb
Copy link
Member

busterb commented May 22, 2017

Sounds good to me. It might be even better to tie this to machine_id so if it reconnects you can still see it is CFO-DESKTOP (or rather CFO-LAPTOP, who uses desktops these days :)

@busterb
Copy link
Member

busterb commented May 22, 2017

hey @darkbushido @clee-r7 please give this a gander (they're busy fixing a bunch of stuff in the database now, so making sure they're looped in)

@OJ
Copy link
Contributor Author

OJ commented May 22, 2017

Yeah that's a good idea. Would be great to have that persist across sessions. However, it'd be better to tie to the soon_to_be_implemented session ID, because we may have multiple sessions on the same machine with different labels?

@busterb
Copy link
Member

busterb commented May 22, 2017

Oh, you're thinking in terms of that session ID! Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants