Skip to content

Commit 45128b0

Browse files
xiongzhongjiangkdave
authored andcommitted
btrfs: change btrfs_pin_log_trans to return void
btrfs_pin_log_trans defines the variable "ret" for return value, but it is not modified after initialization. Further, I find that none of the callers do handles the return value, so it is safe to drop the unneeded "ret" and make it return void. Signed-off-by: zhong jiang <zhongjiang@huawei.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 556f3ca commit 45128b0

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

fs/btrfs/tree-log.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,11 @@ static int join_running_log_trans(struct btrfs_root *root)
205205
* until you call btrfs_end_log_trans() or it makes any future
206206
* log transactions wait until you call btrfs_end_log_trans()
207207
*/
208-
int btrfs_pin_log_trans(struct btrfs_root *root)
208+
void btrfs_pin_log_trans(struct btrfs_root *root)
209209
{
210-
int ret = -ENOENT;
211-
212210
mutex_lock(&root->log_mutex);
213211
atomic_inc(&root->log_writers);
214212
mutex_unlock(&root->log_mutex);
215-
return ret;
216213
}
217214

218215
/*

fs/btrfs/tree-log.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ int btrfs_del_inode_ref_in_log(struct btrfs_trans_handle *trans,
6565
const char *name, int name_len,
6666
struct btrfs_inode *inode, u64 dirid);
6767
void btrfs_end_log_trans(struct btrfs_root *root);
68-
int btrfs_pin_log_trans(struct btrfs_root *root);
68+
void btrfs_pin_log_trans(struct btrfs_root *root);
6969
void btrfs_record_unlink_dir(struct btrfs_trans_handle *trans,
7070
struct btrfs_inode *dir, struct btrfs_inode *inode,
7171
int for_rename);

0 commit comments

Comments
 (0)