feat(ci): improve test coverage

Author: rande

commands/ci_dump_meta.go

@@ -47,7 +47,6 @@ type CiDumpMetaCommand struct {
 }
 
 func (c *CiDumpMetaCommand) Run(args []string) int {
-
 	cmdFlags := flag.NewFlagSet("ci:meta", flag.ContinueOnError)
 	cmdFlags.Usage = func() {
 		c.Ui.Output(c.Help())

commands/ci_dump_meta_test.go

@@ -98,3 +98,20 @@ func Test_Ci_Dump_Meta_With_Values(t *testing.T) {
 
 	os.Remove(path)
 }
+
+func Test_Ci_Dump_Meta_Help(t *testing.T) {
+	c := &CiDumpMetaCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.True(t, len(c.Help()) > 0)
+	assert.True(t, len(c.Synopsis()) > 0)
+}
+
+func Test_Ci_Dump_Meta_InvalidRun(t *testing.T) {
+	c := &CiDumpMetaCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.Equal(t, 1, c.Run([]string{"--foobar"}))
+}

commands/ci_dump_revision_test.go

@@ -48,3 +48,20 @@ func Test_Ci_Dump_Revision(t *testing.T) {
 
 	os.Remove(path)
 }
+
+func Test_Ci_Revision_Help(t *testing.T) {
+	c := &CiDumpRevisionCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.True(t, len(c.Help()) > 0)
+	assert.True(t, len(c.Synopsis()) > 0)
+}
+
+func Test_Ci_Dump_Revision_InvalidRun(t *testing.T) {
+	c := &CiDumpRevisionCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.Equal(t, 1, c.Run([]string{"--foobar"}))
+}

commands/dump_readme.go

@@ -6,6 +6,7 @@
 package commands
 
 import (
+	"flag"
 	"fmt"
 	"github.com/mitchellh/cli"
 	"sort"
@@ -19,6 +20,18 @@ type DumpReadmeCommand struct {
 }
 
 func (c *DumpReadmeCommand) Run(args []string) int {
+
+	cmdFlags := flag.NewFlagSet("dump:readme", flag.ContinueOnError)
+	cmdFlags.Usage = func() {
+		c.Ui.Output(c.Help())
+	}
+
+	cmdFlags.BoolVar(&c.Verbose, "verbose", false, "")
+
+	if err := cmdFlags.Parse(args); err != nil {
+		return 1
+	}
+
 	mk := make([]string, len(c.Commands))
 
 	i := 0
@@ -54,5 +67,5 @@ func (c *DumpReadmeCommand) Synopsis() string {
 }
 
 func (c *DumpReadmeCommand) Help() string {
-	return strings.TrimSpace("")
+	return strings.TrimSpace("Dump the command readme.")
 }

commands/dump_readme_test.go

@@ -21,3 +21,20 @@ func Test_Dump_Readme(t *testing.T) {
 
 	assert.Equal(t, 0, code)
 }
+
+func Test_Dump_Readme_Help(t *testing.T) {
+	c := &DumpReadmeCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.True(t, len(c.Help()) > 0)
+	assert.True(t, len(c.Synopsis()) > 0)
+}
+
+func Test_Dump_Readme_InvalidRun(t *testing.T) {
+	c := &DumpReadmeCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.Equal(t, 1, c.Run([]string{"--foobar"}))
+}

commands/project_build_artifacts_test.go

@@ -100,3 +100,20 @@ func Test_Project_Builds_Artifacts(t *testing.T) {
 	})
 
 }
+
+func Test_Project_Builds_Artifacts_Help(t *testing.T) {
+	c := &ProjectBuildArtifactCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.True(t, len(c.Help()) > 0)
+	assert.True(t, len(c.Synopsis()) > 0)
+}
+
+func Test_Project_Builds_Artifacts_InvalidRun(t *testing.T) {
+	c := &ProjectBuildArtifactCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.Equal(t, 1, c.Run([]string{"--foobar"}))
+}

commands/project_builds_list_test.go

@@ -52,3 +52,20 @@ func Test_Project_BuildsList_From_Args(t *testing.T) {
 		assert.Equal(t, 0, code)
 	})
 }
+
+func Test_Project_BuildsList_Help(t *testing.T) {
+	c := &ProjectBuildsListCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.True(t, len(c.Help()) > 0)
+	assert.True(t, len(c.Synopsis()) > 0)
+}
+
+func Test_Project_BuildsList_InvalidRun(t *testing.T) {
+	c := &ProjectBuildsListCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.Equal(t, 1, c.Run([]string{"--foobar"}))
+}

commands/project_list_test.go

@@ -48,3 +48,20 @@ func Test_Project_List(t *testing.T) {
 		assert.Equal(t, expected, ui.OutputWriter.String())
 	})
 }
+
+func Test_Project_List_Help(t *testing.T) {
+	c := &ProjectsListCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.True(t, len(c.Help()) > 0)
+	assert.True(t, len(c.Synopsis()) > 0)
+}
+
+func Test_Project_List_InvalidRun(t *testing.T) {
+	c := &ProjectsListCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.Equal(t, 1, c.Run([]string{"--foobar"}))
+}

commands/s3_archive_test.go

@@ -0,0 +1,29 @@
+// Copyright © 2016 Thomas Rabaix <thomas.rabaix@gmail.com>.
+//
+// Use of this source code is governed by an MIT-style
+// license that can be found in the LICENSE file.
+
+package commands
+
+import (
+	"github.com/mitchellh/cli"
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func Test_S3ArchiveCommand_Help(t *testing.T) {
+	c := &S3ArchiveCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.True(t, len(c.Help()) > 0)
+	assert.True(t, len(c.Synopsis()) > 0)
+}
+
+func Test_S3ArchiveCommand_InvalidRun(t *testing.T) {
+	c := &S3ArchiveCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.Equal(t, 1, c.Run([]string{"--foobar"}))
+}

commands/s3_extract_test.go

@@ -0,0 +1,29 @@
+// Copyright © 2016 Thomas Rabaix <thomas.rabaix@gmail.com>.
+//
+// Use of this source code is governed by an MIT-style
+// license that can be found in the LICENSE file.
+
+package commands
+
+import (
+	"github.com/mitchellh/cli"
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func Test_S3ExtractCommand_Help(t *testing.T) {
+	c := &S3ExtractCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.True(t, len(c.Help()) > 0)
+	assert.True(t, len(c.Synopsis()) > 0)
+}
+
+func Test_S3ExtractCommand_InvalidRun(t *testing.T) {
+	c := &S3ExtractCommand{
+		Ui: &cli.MockUi{},
+	}
+
+	assert.Equal(t, 1, c.Run([]string{"--foobar"}))
+}