Reject operations on local users when the local auth provider is marked disabled#1410
Open
andreas-kupries wants to merge 7 commits into
Open
Reject operations on local users when the local auth provider is marked disabled#1410andreas-kupries wants to merge 7 commits into
andreas-kupries wants to merge 7 commits into
Conversation
andreas-kupries
added
enhancement
crobby
approved these changes
Apr 28, 2026
Collaborator
crobby
left a comment
crobby
left a comment
There was a problem hiding this comment.
Seems reasonable, has tests/docs, just a nit on the one debug log
…ovider note: requires new field settingCache fix: tests - additional setup for new setting cache todo: tests covering the new checks
andreas-kupries
force-pushed
the
local-auth-disable-on-external
branch
from
47f52cd to
da82389
Compare
andreas-kupries
commented
Apr 29, 2026
enables new webhook to work with older rancher without the setting
bigkevmcd
approved these changes
May 11, 2026
assumes that response and error are not non-nil at the same time
bigkevmcd
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#46078
Problem
See issue
Solution
The existing validator for user operations is extended with additional which apply if and only if the local auth provider is marked (per setting) as disabled.
CheckList