Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument with OpenTelemetry #354

Open
agracey opened this issue Sep 22, 2022 · 6 comments
Open

Instrument with OpenTelemetry #354

agracey opened this issue Sep 22, 2022 · 6 comments
Labels
kind/enhancement New feature or request status/later

Comments

@agracey
Copy link

agracey commented Sep 22, 2022

It may be worth adding OpenTelemetry instrumentation to the operator (and cli?) for a few reasons:

  • Metrics for things like nodes connected, early disconnects, update issues or plan retries, etc...
  • Better debugging when something goes wrong since tracing can highlight dependency interactions in a way that is hard to get from stdout logging
  • Learn timing of how our component interacts with other components (kubeapi, rancher, network latency between node and operator, etc...)
  • (opinion) We should be adopting this for more projects and this component might be a lower risk proving ground for the value it can bring

Note: I would not expect that we force everyone to setup jaeger or prometheus. But being able to add the right flags to get the data published would be useful when appropriate.

@agracey
Copy link
Author

agracey commented Sep 22, 2022

@fendrifirasleminnov
Copy link

Hello @agracey ,

Totally agree with you this is needed, i am starting to work on implementing this in rancher code using the opentelemtry SDK, however i see that opentelemetry packages are already there in go.mod with very old versions and can't find where they are use ?

Also when i tried to update them so i can start implementing the SDK lot of other dependencies pkg start showing errors.

Any idea how we can make clean implementation for this ?

@kkaempf
Copy link
Contributor

kkaempf commented Jan 19, 2024

@davidstauffer 👆🏻

@krumware
Copy link

Any updates on this?

@fgiudici fgiudici added the kind/enhancement New feature or request label May 29, 2024
@fgiudici
Copy link
Member

Hey @krumware 👋🏼
no updates on this.
Adding this to the backlog to not get it out of our radar, but there is no plan to work on this feature at present.

@krumware
Copy link

Sounds good thanks for the update. It's starting to come up in convos with Prime customers, so just staying out ahead. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request status/later
Projects
Status: 💡 Backlog
Development

No branches or pull requests

5 participants