Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sizes in config #1769

Open
frelon opened this issue Dec 8, 2022 · 0 comments
Open

Improve sizes in config #1769

frelon opened this issue Dec 8, 2022 · 0 comments
Labels
kind/enhancement New feature or request kind/good first issue Good for newcomers

Comments

@frelon
Copy link
Contributor

frelon commented Dec 8, 2022

In the following config it's hard to know what "size" represents without the comment.

install:
  # size in MiB
  partitions:
    oem:
      label: COS_OEM
      size: 60
      fs: ext4

I think we should use something like https://github.com/docker/go-units to parse sizes instead, making the config look like this:

install:
  partitions:
    oem:
      label: COS_OEM
      size: 60MiB
      fs: ext4

Also this must be backwards-compatible and parse in MiB if no unit is specified.
@frelon frelon added the kind/enhancement New feature or request label Dec 8, 2022
@frelon frelon transferred this issue from rancher/elemental-cli May 23, 2023
@frelon frelon added the kind/good first issue Good for newcomers label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request kind/good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frelon