Add unit tests for Namespace filtering in resources #7465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata-testid attributes for testing purposes and ocmments for readability
cnotv
force-pushed
the
feature/7391-namespace-filtering-tests
branch
from
07d9545 to
8e276c3
Compare
cnotv
requested review from
rak-phillip and
catherineluse
and removed request for
catherineluse
rak-phillip
reviewed
Nov 17, 2022
cnotv
force-pushed
the
feature/7391-namespace-filtering-tests
branch
from
20657f7 to
547c846
Compare
|
It looks like cluster explorer is no longer rendering for downstream clusters. The error says something about the namespace filter. could it have been caused by a change in this PR?
|
|
@catherineluse I have created a new issue here: #7495 |
|
@catherineluse Taking a look to the code, I see nothing which may cause issues, rather the other way around, to prevent access function when undefined. In the same way I don't see any other commit either since a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7391
These tests are aimed to ensure the functionalities of the namespace filter an part of the Workload fetching data capabilities.
Occurred changes and/or fixed issues
NamespaceFiltercomponent in case of missing props or data, e.g.currentProductdata-testidattributes for selecting component.Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video