Fix editing local rke1 and eks clusters #12583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport v2.10.0 |
18 tasks
codyrancher
previously approved these changes
Nov 12, 2024
|
Updated to fix an e2e test: https://github.com/rancher/dashboard/actions/runs/11803005939/job/32886518312?pr=12583#step:9:84 Looks like these CLI downloads succeed now, on master anyway |
codyrancher
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12506
Fixes #12339
Fixes #12576
Occurred changes and/or fixed issues
This PR reverts #12177 as well as much of #9868
Technical notes summary
I reverted most of #9868 and moved a critical component of that fix into a display-only property, so it would not interfere with iframed edit pages (causing #12506 and #12339). I also found a simpler approach to determining whether or not a cluster is imported, which doesn't depend on ember query params: as noted in pre-existing inline documentation, constructing those ember params involves "much indirect mapping" -- in other words, it's difficult to follow.
Areas or cases that should be tested
Verify the provider/distro column of the cluster management list view as well as the edit config view for each of the following:
local clusters:
downstream clusters:
Areas which could experience regressions
The provider/distro column of the cluster management list view, as well as any iframed ember cluster edit page, could experience regressions. We also need to be sure we haven't re-introduced:
#6836
#11874
Screenshot/Video
release-2.10:
this pr:
Checklist