-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new project/namespace experience given server-side pagination #11674
Comments
@richard-cox has there been any issues or measurements that show that this page is problematic? I would've guessed that these resources are small enough that findall wouldn't be an issue here.
Wouldn't it be the inverse? Wouldn't we need to fetch all namespaces to get the ones that aren't in a project? If we have a performance issue on this page I have a feeling that we're going to need backend work for this. It seems like this would be a join between the project and namespace tables (assuming a table per resource is the schema) and a groupby project id when sending these back. Anything short of that will require us to fetch all namespaces I think. There may be a special case here for advanced filtering where we have to be able to filter on two resources, namespaces and projects. I think we want to avoid paginating this page there's not a performance bottleneck. |
The main issue is admins on the
Maybe the text was badly worded, but the crux is we should show a page of namespaces sorted by project id annotation which will get us the grouped by project part... but also show the projects groups which contain no namespaces. We don't have a projects list so that's the only place users can add namespaces to an empty project. |
I understand where the issue could possibly occur, but, I want to make sure we have a justifiable reason for making changes to this page. As long as we have a documented issue around performance on the projects/namespaces page from a customer or we've demonstrated the performance issue, I'm on board. I haven't seen either of these and would like to verify so we don't waste effort.
Got it, that makes sense. |
It should be quite straight forward to observe the performance issues given 1-2k namespaces. However happy to bump it down the priority stack given effort required vs other changes. |
Linking rancher/rancher#48637 |
The text was updated successfully, but these errors were encountered: