RollbackWorkloadDialog: Direct Manipulation of CSS in sizeDialog()
Function
#10559
Labels
kind/tech-debt
Technical debt
sizeDialog()
Function
#10559
The
sizeDialog()
function in the close workload dialog directly modifies CSS properties of elements owned and maintained byvue-js-modal
. This approach raises concerns about maintainability for two reasons:vue-js-modal
or our modal implementation could change - leading to unintended regressions in the behavior of this dialogProposed Change
Instead of directly manipulating CSS, consider emitting an event from the component to signal the need for dialog sizing changes.
Referenced Code
dashboard/shell/dialog/RollbackWorkloadDialog.vue
Lines 165 to 172 in ddbb569
The text was updated successfully, but these errors were encountered: