Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.8] Bump dependencies for v2.8.8 #395

Merged
merged 4 commits into from
Sep 19, 2024
Merged

[v2.8] Bump dependencies for v2.8.8 #395

merged 4 commits into from
Sep 19, 2024

Conversation

pmatseykanets
Copy link
Contributor

@pmatseykanets pmatseykanets commented Sep 19, 2024 •
edited
Loading 

git ls-remote upstream v2.8.8
e61d915fb7af485842e990e7d6e5a8813fe65844	refs/tags/v2.8.8

@pmatseykanets pmatseykanets self-assigned this Sep 19, 2024
@pmatseykanets pmatseykanets requested a review from a team as a code owner September 19, 2024 14:44
@pmatseykanets pmatseykanets marked this pull request as draft September 19, 2024 14:44
pmatseykanets
pmatseykanets commented Sep 19, 2024
View reviewed changes
go.mod Outdated
Comment on lines 18 to 19
github.com/rancher/rancher/pkg/apis v0.0.0-20240919014759-3499f6b9c72a
github.com/rancher/rancher/pkg/client v0.0.0-20240919014759-3499f6b9c72a
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will be bumped one more time once r/r is tagged.

pmatseykanets
pmatseykanets commented Sep 19, 2024
View reviewed changes
go.mod
Comment on lines +3 to +5
go 1.22.0

toolchain go1.22.7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matching r/r v2.8 and Go toolchain in bci images.

@pmatseykanets pmatseykanets marked this pull request as ready for review September 19, 2024 15:18
crobby
crobby previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me

enrichman
enrichman previously approved these changes Sep 19, 2024
View reviewed changes
@pmatseykanets pmatseykanets dismissed stale reviews from enrichman and crobby via 3b9e7a3 September 19, 2024 17:04
@pmatseykanets pmatseykanets merged commit 3d9eca3 into rancher:v2.8 Sep 19, 2024
1 check passed
@pmatseykanets pmatseykanets deleted the bump-deps-v2.8.8 branch September 19, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tashima42 tashima42 tashima42 approved these changes

@crobby crobby crobby approved these changes

@enrichman enrichman enrichman left review comments

@JonCrowther JonCrowther Awaiting requested review from JonCrowther

Assignees

@pmatseykanets pmatseykanets

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmatseykanets @crobby @enrichman @tashima42