-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging for macOS #28
Commits on Dec 17, 2020
-
vue.config.js: set target to electron
This avoids issues with require('electron') using fs.readSync() breaking when we end up packaging it.
Configuration menu - View commit details
-
Copy full SHA for 98f9ba8 - Browse repository at this point
Copy the full SHA 98f9ba8View commit details -
.gitignore: Add more generated file directories
These are the defaults for electron-forge.
Configuration menu - View commit details
-
Copy full SHA for c35704e - Browse repository at this point
Copy the full SHA c35704eView commit details -
When packaged, we will not be able to load file:// URLs (currently not an issue because the dev workflow includes running a local HTTP server). So we will need an additional protocol for loading resources.
Configuration menu - View commit details
-
Copy full SHA for 7442306 - Browse repository at this point
Copy the full SHA 7442306View commit details -
package.json: Add @electron-forge/cli
This will be used to package the application.
Configuration menu - View commit details
-
Copy full SHA for f5abc90 - Browse repository at this point
Copy the full SHA f5abc90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91dc6ab - Browse repository at this point
Copy the full SHA 91dc6abView commit details -
package.json: Drop deb & rpm builders for electron-forge
We will, at the short term at least, not target Linux.
Configuration menu - View commit details
-
Copy full SHA for 76131a8 - Browse repository at this point
Copy the full SHA 76131a8View commit details -
forge.config.js: Move forge config outside package.json
This will be needed later as we get more complex electron-forge configuration.
Configuration menu - View commit details
-
Copy full SHA for f1efe02 - Browse repository at this point
Copy the full SHA f1efe02View commit details -
K8s.vue: drop
window.
prefix beforerequire()
This was making it hard for webpack to figure out dependencies.
Configuration menu - View commit details
-
Copy full SHA for acf8ca6 - Browse repository at this point
Copy the full SHA acf8ca6View commit details -
K8s.vue: read versions as a JS module
When packaged, we can't just read files off the filesystem (as the layout will be different); however, we don't really need to, as we can just import it as a module, at which point webpack can find the file ahead of time.
Configuration menu - View commit details
-
Copy full SHA for 2e8f149 - Browse repository at this point
Copy the full SHA 2e8f149View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f81a78 - Browse repository at this point
Copy the full SHA 0f81a78View commit details -
src/resources.js: Add abstraction for resources/ directory
This is needed as the path will be different when the application is packaged.
Configuration menu - View commit details
-
Copy full SHA for a79d5bc - Browse repository at this point
Copy the full SHA a79d5bcView commit details -
src/window: use app:// protocol when not in DEV
Because file:// doesn't really work due to security restrictions.
Configuration menu - View commit details
-
Copy full SHA for a65562c - Browse repository at this point
Copy the full SHA a65562cView commit details -
package.json: Add @electron-forge/plugin-webpack
This will be needed for Vue.js integration
Configuration menu - View commit details
-
Copy full SHA for 4f1c628 - Browse repository at this point
Copy the full SHA 4f1c628View commit details -
forge.config.js: Add packaging script.
This does all the fixups necessary to make the build work correctly.
Configuration menu - View commit details
-
Copy full SHA for ee3e440 - Browse repository at this point
Copy the full SHA ee3e440View commit details -
.github/workflows: Add packaging workflow
This is useful to have artifacts to test locally if necessary.
Configuration menu - View commit details
-
Copy full SHA for c771c09 - Browse repository at this point
Copy the full SHA c771c09View commit details