Handle title="" and ga-* event overrides

Author: panrafal

README.md

@@ -69,38 +69,28 @@ By using `ga-on="init"` you can call `ga` as soon as the html is parsed:
 
 ## Use ga directive's auto events
 
-If `ga` attribute is empty, the event is guesses from the context. Following examples
-are equivalent:
+If `ga` attribute is empty, the event is guesses from the context as follows:
 
-```html
-<div ga>LABEL</div>
-<div ga="'send', 'event', 'button', 'click', 'LABEL'">LABEL</div>
-```
+**category**
 
-```html
-<a href="#" ga>LABEL</a>
-<a href="#" ga="'send', 'event', 'button', 'click', 'LABEL'">LABEL</a>
-```
+- `link-out` if href begins with `http://`
+- `link-in` if href is anything else, except `#`
+- `button` for anything else
 
-```html
-<a href="#anchor" ga>LABEL</a>
-<a href="#anchor" ga="'send', 'event', 'button', '#anchor', 'LABEL'">LABEL</a>
-```
+**action**
 
-```html
-<a href="/" ga>LABEL</a>
-<a href="/" ga="'send', 'event', 'link-in', '/', 'LABEL'">LABEL</a>
-```
+- value of `href` attribute if present
+- `click` for anything else
 
-```html
-<a href="https://github.com/panrafal/angular-ga" ga>LABEL</a>
-<a href="https://github.com/panrafal/angular-ga" ga="'send', 'event', 'link-out', 'https://github.com/panrafal/angular-ga', 'LABEL'">LABEL</a>
-```
+**label**
+
+- value of `title` attribute if present
+- for `input` elements value of `value` attribute if present
+- text contents for anything else
+
+You can use attributes `ga-category`, `ga-action`, `ga-label` and `ga-value` to override
+default behaviour.
 
-```html
-<input type="submit" value="SUBMIT" ga />
-<input type="submit" value="SUBMIT" ga="'send', 'event', 'button', 'click', 'SUBMIT'" />
-```
 
 
 [![githalytics.com alpha](https://cruel-carlota.pagodabox.com/1b31cde4eb48524cf5194d3c2bf1ef68 "githalytics.com")](http://githalytics.com/panrafal/angular-ga)

ga.js

@@ -11,10 +11,11 @@ angular.module('ga', [])
                 }
                 return;
             }
+            console.log('ga', arguments);
             if ($window.ga) {
                 $window.ga.apply(this, arguments);
             }
-        }
+        };
 
         return ga;
     }])
@@ -45,13 +46,17 @@ angular.module('ga', [])
                     // auto command
                     var href = $element.attr('href');
                     if (href && href === '#') href = '';
-                    var category = href && href[0] !== '#' ? (href.match(/\/\//) ? 'link-out' : 'link-in') : 'button',
-                        action = href ? href : 'click',
-                        label = ($element[0].tagName.match(/input/i) ? $element.attr('value') : $element.text()).substr(0, 64);
-                    command = ['send', 'event', category, action, label];
+                    var category = $attrs.gaCategory ? $scope.$eval($attrs.gaCategory) : 
+                            (href && href[0] !== '#' ? (href.match(/\/\//) ? 'link-out' : 'link-in') : 'button'),
+                        action = $attrs.gaAction ? $scope.$eval($attrs.gaAction) : 
+                            (href ? href : 'click'),
+                        label = $attrs.gaLabel ? $scope.$eval($attrs.gaLabel) : 
+                            ($element[0].title || ($element[0].tagName.match(/input/i) ? $element.attr('value') : $element.text())).substr(0, 64),
+                        value = $attrs.gaValue ? $scope.$eval($attrs.gaValue) : 0;
+                    command = ['send', 'event', category, action, label, value];
                 }
                 ga.apply(null, command);
-            }
+            };
 
             if (bindToEvent === 'init') {
                 onEvent();

package.json

@@ -1,7 +1,7 @@
 {
   "name": "angular-ga",
   "description": "Google Universal Analytics adapter for AngularJS",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "author": "Rafal Lindemann <rl@stamina.pl>",
   "main": "ga.js",
   "repository": {

test/spec.js

@@ -83,6 +83,11 @@ describe('ga', function () {
             expect(window.ga).toHaveBeenCalledWith('send', 'event', 'button', '#anchor', 'Label');
         })
 
+        it('should have title', function() {
+            el = compileElement('<a href="#anchor" title="Title" ga>Label</a>').triggerHandler('click')
+            expect(window.ga).toHaveBeenCalledWith('send', 'event', 'button', '#anchor', 'Title');
+        })
+
         it('should click link', function() {
             el = compileElement('<a href="/" ga>Label</a>').triggerHandler('click')
             expect(window.ga).toHaveBeenCalledWith('send', 'event', 'link-in', '/', 'Label');
@@ -98,6 +103,13 @@ describe('ga', function () {
             expect(window.ga).toHaveBeenCalledWith('send', 'event', 'button', 'click', 'Submit');
         })
 
+        it('should have special attributes', function() {
+            el = compileElement('<a href="#" title="Title" ga ga-category="cat" ga-action="act" ga-label="lab" ga-value="1">Label</a>').triggerHandler('click')
+            expect(window.ga).toHaveBeenCalledWith('send', 'event', 'cat', 'act', 'lab', 1);
+        })
+
+
+
     });