Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locked version vs. missing lock file #249

Closed
szepeviktor opened this issue Oct 24, 2023 · 1 comment · Fixed by #251
Closed

locked version vs. missing lock file #249

szepeviktor opened this issue Oct 24, 2023 · 1 comment · Fixed by #251
Labels
enhancement New feature or request

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Oct 24, 2023

My feature title

Would you merge a PR that adds an argument to fail the job when dependencies: locked but the lock file is missing?

Background/problem

I'd like to see that problem in form of a ❌

# If there is no composer.lock file, then use the `update` command.
if [ -z "${composer_lock}" ]; then
composer_command="update"
fi

@szepeviktor szepeviktor added the enhancement New feature or request label Oct 24, 2023
@ramsey
Copy link
Owner

ramsey commented Oct 24, 2023

Sure thing. As long as it's a configurable argument, I think that's be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants