Skip to content

Commit fd96a4f

Browse files
committed
[eslint config] [*] [refactor] use object spread instead of Object.assign
1 parent 81157ee commit fd96a4f

File tree

7 files changed

+7
-13
lines changed

7 files changed

+7
-13
lines changed

packages/eslint-config-airbnb-base/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@
8888
},
8989
"dependencies": {
9090
"confusing-browser-globals": "^1.0.11",
91-
"object.assign": "^4.1.4",
9291
"object.entries": "^1.1.5"
9392
}
9493
}

packages/eslint-config-airbnb-base/whitespace-async.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#!/usr/bin/env node
22

3-
const assign = require('object.assign');
43
const entries = require('object.entries');
54
const { ESLint } = require('eslint');
65

@@ -20,7 +19,7 @@ function getSeverity(ruleConfig) {
2019
}
2120

2221
async function onlyErrorOnRules(rulesToError, config) {
23-
const errorsOnly = assign({}, config);
22+
const errorsOnly = { ...config };
2423
const cli = new ESLint({
2524
useEslintrc: false,
2625
baseConfig: config

packages/eslint-config-airbnb-base/whitespace.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const { CLIEngine } = require('eslint');
44

55
if (CLIEngine) {
66
/* eslint no-inner-declarations: 0 */
7-
const assign = require('object.assign');
87
const entries = require('object.entries');
98
const whitespaceRules = require('./whitespaceRules');
109

@@ -23,7 +22,7 @@ if (CLIEngine) {
2322
}
2423

2524
function onlyErrorOnRules(rulesToError, config) {
26-
const errorsOnly = assign({}, config);
25+
const errorsOnly = { ...config };
2726
const cli = new CLIEngine({ baseConfig: config, useEslintrc: false });
2827
const baseRules = cli.getConfigForFile(require.resolve('./')).rules;
2928

packages/eslint-config-airbnb/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
"homepage": "https://github.com/airbnb/javascript",
6868
"dependencies": {
6969
"eslint-config-airbnb-base": "^15.0.0",
70-
"object.assign": "^4.1.4",
7170
"object.entries": "^1.1.5"
7271
},
7372
"devDependencies": {

packages/eslint-config-airbnb/rules/react.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
const assign = require('object.assign');
21
const baseStyleRules = require('eslint-config-airbnb-base/rules/style').rules;
32

43
const dangleRules = baseStyleRules['no-underscore-dangle'];
@@ -17,9 +16,10 @@ module.exports = {
1716
// View link below for react rules documentation
1817
// https://github.com/jsx-eslint/eslint-plugin-react#list-of-supported-rules
1918
rules: {
20-
'no-underscore-dangle': [dangleRules[0], assign({}, dangleRules[1], {
19+
'no-underscore-dangle': [dangleRules[0], {
20+
...dangleRules[1],
2121
allow: dangleRules[1].allow.concat(['__REDUX_DEVTOOLS_EXTENSION_COMPOSE__']),
22-
})],
22+
}],
2323

2424
// Specify whether double or single quotes should be used in JSX attributes
2525
// https://eslint.org/docs/rules/jsx-quotes

packages/eslint-config-airbnb/whitespace-async.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#!/usr/bin/env node
22

3-
const assign = require('object.assign');
43
const entries = require('object.entries');
54
const { ESLint } = require('eslint');
65

@@ -20,7 +19,7 @@ function getSeverity(ruleConfig) {
2019
}
2120

2221
async function onlyErrorOnRules(rulesToError, config) {
23-
const errorsOnly = assign({}, config);
22+
const errorsOnly = { ...config };
2423
const cli = new ESLint({
2524
useEslintrc: false,
2625
baseConfig: config

packages/eslint-config-airbnb/whitespace.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const { CLIEngine } = require('eslint');
44

55
if (CLIEngine) {
66
/* eslint no-inner-declarations: 0 */
7-
const assign = require('object.assign');
87
const entries = require('object.entries');
98
const whitespaceRules = require('./whitespaceRules');
109

@@ -23,7 +22,7 @@ if (CLIEngine) {
2322
}
2423

2524
function onlyErrorOnRules(rulesToError, config) {
26-
const errorsOnly = assign({}, config);
25+
const errorsOnly = { ...config };
2726
const cli = new CLIEngine({ baseConfig: config, useEslintrc: false });
2827
const baseRules = cli.getConfigForFile(require.resolve('./')).rules;
2928

0 commit comments

Comments
 (0)