Fixed a bug how finished how increments completions.

When the test is not reset after its been completed i.e. the user will always
see the alternative they started with, `finished` was incrementing the
completion count of the alternative even if the user had finished the test
before. This lead to situations where altenative's completion count was bigger
its participant count.

Author: jpvanhal

CHANGES.rst

@@ -3,6 +3,12 @@ Changelog
 
 Here you can see the full list of changes between each Flask-Split release.
 
+0.1.3 (2012-05-30)
+^^^^^^^^^^^^^^^^^^
+
+- Fixed :func:`finished` incrementing alternative's completion count multiple
+  times, when the test is not reset after it has been finished.
+
 0.1.2 (2012-03-15)
 ^^^^^^^^^^^^^^^^^^
 

flask_split/core.py

@@ -120,10 +120,15 @@ def finished(experiment_name, reset=True):
             return
         alternative_name = _get_session().get(experiment.key)
         if alternative_name:
-            alternative = Alternative(alternative_name, experiment_name)
-            alternative.increment_completion()
+            if '%s:finished' % experiment.key not in _get_session():
+                alternative = Alternative(alternative_name, experiment_name)
+                alternative.increment_completion()
             if reset:
                 _get_session().pop(experiment.key, None)
+                _get_session().pop('%s:finished' % experiment.key, None)
+                session.modified = True
+            else:
+                _get_session()['%s:finished' % experiment.key] = 1
                 session.modified = True
     except ConnectionError:
         if not current_app.config['SPLIT_DB_FAILOVER']:

setup.py

@@ -18,7 +18,7 @@ def run(self):
 
 setup(
     name='Flask-Split',
-    version='0.1.2',
+    version='0.1.3',
     url='http://github.com/jpvanhal/flask-split',
     license='MIT',
     author='Janne Vanhala',

tests/test_extension.py

@@ -117,12 +117,25 @@ def test_finished_does_not_clear_out_the_users_session_if_reset_is_false(self):
 
         assert session['split'] == {"link_color": alternative_name}
         finished('link_color', reset=False)
-        assert session['split'] == {"link_color": alternative_name}
+        assert session['split'] == {
+            "link_color": alternative_name,
+            "link_color:finished": 1
+        }
 
     def test_finished_does_nothing_if_experiment_was_not_started_by_the_user(self):
         session['split'] = None
         finished('some_experiment_not_started_by_the_user')
 
+    def test_finished_does_not_incr_completed_twice_if_reset_is_false(self):
+        Experiment.find_or_create('link_color', 'blue', 'red')
+        alternative_name = ab_test('link_color', 'blue', 'red')
+
+        finished('link_color', reset=False)
+        finished('link_color', reset=False)
+
+        completion_count = Alternative(alternative_name, 'link_color').completed_count
+        assert completion_count == 1
+
     def test_conversions_return_conversion_rates_for_alternatives(self):
         Experiment.find_or_create('link_color', 'blue', 'red')
         alternative_name = ab_test('link_color', 'blue', 'red')