Add ability to intercept "handleMethodCall" #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 22, 2015 14:09
Conflicts: src/test/java/ch/ralscha/extdirectspring/controller/ApiControllerTest.java
ralscha
added a commit
that referenced
this pull request
Jan 22, 2015
Add ability to intercept "handleMethodCall"
Author
|
i have to make the injection optional, tests failed :/ this was my first ever pull request sorry... |
Owner
|
No problem. Just noticed the same and wanted to fix it. But I'm glad if you can do it. |
Author
|
it is fixed now, the build of the pull request runs without failing tests. Gesendet: Donnerstag, 22. Januar 2015 um 15:14 Uhr No problem. Just noticed the same and wanted to fix it. But I'm glad if you can do it. —
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to access the ExtRequest and its Metadata I created the ExtRequestListener that allows to hook before and after the handleMethodCall. If there is a better way to solve this, please le me know :)
Concrete example:
In addition to the default method args, the client sends audit information to the server. I did not want to change the server API, it should be transparent to the developer that this information was send. The ExtRequestLIstener will extract the audit information from the ExtDirectRequest and set it to a ThreadLocal field in our AuditController Bean.