Show ✗ when choosing ‘no’ in interactive mode

[Primajin]

• I have read the list of known issues before filing this issue.
• I have searched for similiar issues before filing this issue.

• node version: v12.5.0
• npm version: 6.9.2
• npm-check-updates version: 3.1.13

---

Just curious about people's opinions, when choosing ‘no’ in interactive mode, we still put the green check mark in the front - how about we change that to a red x in that case?

Before:

✔️ Do you want to upgrade: axios ^0.18.1 → ^0.19.0? … no
✔ Do you want to upgrade: eslint ^5.16.0 → ^6.0.1? … yes
? Do you want to upgrade: eslint-plugin-flowtype 2.50.3 → 3.11.1? › (Y/n)

After:

✘ Do you want to upgrade: axios ^0.18.1 → ^0.19.0? … no
✔ Do you want to upgrade: eslint ^5.16.0 → ^6.0.1? … yes
? Do you want to upgrade: eslint-plugin-flowtype 2.50.3 → 3.11.1? › (Y/n)

Happy to create a PR if you like it.

Also: Should we imply -u when using interactive mode? I find it kind of counter intuitive when it asks me Do you want to upgrade: eslint ^5.16.0 → ^6.0.1? … yes and since I didn’t run it with -u it’s still on dry-run… 🤔

[raineorshine]

We should print an ✗ when the user chooses no. That's a bug (notice how it shows an ✗ if you kill the process, e.g. with Cmd + C, during a prompt). PR Welcome.

As for implying -u, that was exactly the behavior that -a had in ncu v2, and people got all sorts of confused. The package is upgraded if and only if -u is specified; simple. If anything, we could print a warning. Theoretically it's possible that a user may want to interactively run ncu and pipe the results of --jsonUpgraded somewhere without modifying the package.json.

[Primajin]

Alright fair enough, then I'll concentrate only on the ✗ part!

[Primajin]

Hmmm this seems to be rather a problem with prompts

const prompts = require('prompts');

(async () => {
    const response = await prompts({
        type: 'confirm',
        name: 'value',
        message: 'Do you want to upgrade: stuff?',
        initial: true
    });

    console.log(response.value);
})();

Gives me

• a no and a green check mark on N
• a yes and a red cross on CTRL+C
• a yes and a green check mark on enter
• a yes and a green check mark on Y

while the last two are fine the first two are very weird 🤔

EDIT: opened terkelg/prompts#180

[raineorshine]

Agreed! Thanks for following up on this.