Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive CLI has no quit or exit command. #1414

Open
1 task done
vassudanagunta opened this issue May 22, 2024 · 4 comments
Open
1 task done

interactive CLI has no quit or exit command. #1414

vassudanagunta opened this issue May 22, 2024 · 4 comments

Comments

@vassudanagunta
Copy link

vassudanagunta commented May 22, 2024


Currently the only way, AFAIK, is to issue a terminal kill command. You can also press ENTER and then not ENTER but n at the next prompt (which is unintuitive when looking at the initial list).

Ideally q or x to exit with nothing upgraded or changed.

If agreed, I can take a stab at a PR when I get some free time.

@raineorshine
Copy link
Owner

Thanks for the suggestion. I'd be happy with q for quit.

@vassudanagunta vassudanagunta changed the title interactive CLI has now quit or exit command. interactive CLI has no quit or exit command. May 30, 2024
@ZaLiTHkA
Copy link

ZaLiTHkA commented Jun 3, 2024

just thinking out loud here, but perhaps this could be "fixed" by simply updating the input descriptions for interactive mode?

pressing "escape" cancels the interactive mode prompt, returning the user to their terminal, as (I imagine) the OP would expect q or x to do.

@vassudanagunta
Copy link
Author

vassudanagunta commented Jun 3, 2024

@ZaLiTHkA Good to know. But not very obvious or intuitive: In my experience, ESC is a standard idiom for cancellation in GUI apps. If I am remembering correctly, all the CLIs I've used exit on q or x. If I am not, I would suggest that it match most user expectations / CLI conventions. For me personally, I am fine with ESC.

@ZaLiTHkA
Copy link

ZaLiTHkA commented Jun 3, 2024

@vassudanagunta I agree with you on that point, it's definitely not very "intuitive" as it is right now.

on the other hand, the fact that there is already a mechanism in place to "cancel" interactive mode also means that adding support for a q or x shortcut to do the same thing shouldn't need entirely new functionality, just a small adjustment to which key actually triggers it.

either way, a short message in the initial usage notes would clear this up for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants