Skip to content

Commit c71dc65

Browse files
justin808gauravtiwari
authored andcommitted
Remove default from rules (#2662)
https://webpack.js.org/configuration/module/#ruleparser Default is requireEnsure: false, // disable require.ensure
1 parent 82a1332 commit c71dc65

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

package/environments/__tests__/base.js

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,37 +31,41 @@ describe('Environment', () => {
3131

3232
test('should return multi file entry points', () => {
3333
const config = environment.toWebpackConfig()
34-
expect(config.entry.multi_entry.sort()).toEqual(
35-
[
36-
resolve('app', 'javascript', 'packs', 'multi_entry.css'),
37-
resolve('app', 'javascript', 'packs', 'multi_entry.js')
38-
]
39-
)
34+
expect(config.entry.multi_entry.sort()).toEqual([
35+
resolve('app', 'javascript', 'packs', 'multi_entry.css'),
36+
resolve('app', 'javascript', 'packs', 'multi_entry.js')
37+
])
4038
})
4139

4240
test('should return output', () => {
4341
const config = environment.toWebpackConfig()
4442
expect(config.output.filename).toEqual('js/[name]-[contenthash].js')
45-
expect(config.output.chunkFilename).toEqual('js/[name]-[contenthash].chunk.js')
43+
expect(config.output.chunkFilename).toEqual(
44+
'js/[name]-[contenthash].chunk.js'
45+
)
4646
})
4747

4848
test('should return default loader rules for each file in config/loaders', () => {
4949
const config = environment.toWebpackConfig()
5050
const defaultRules = Object.keys(rules)
5151
const configRules = config.module.rules
5252

53-
expect(defaultRules.length).toEqual(7)
54-
expect(configRules.length).toEqual(8)
53+
expect(defaultRules.length).toEqual(6)
54+
expect(configRules.length).toEqual(6)
5555
})
5656

5757
test('should return cache path for nodeModules rule', () => {
58-
const nodeModulesLoader = rules.nodeModules.use.find(rule => rule.loader === 'babel-loader')
58+
const nodeModulesLoader = rules.nodeModules.use.find(
59+
(rule) => rule.loader === 'babel-loader'
60+
)
5961

6062
expect(nodeModulesLoader.options.cacheDirectory).toBeTruthy()
6163
})
6264

6365
test('should return cache path for babel-loader rule', () => {
64-
const babelLoader = rules.babel.use.find(rule => rule.loader === 'babel-loader')
66+
const babelLoader = rules.babel.use.find(
67+
(rule) => rule.loader === 'babel-loader'
68+
)
6569

6670
expect(babelLoader.options.cacheDirectory).toBeTruthy()
6771
})

package/environments/base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ module.exports = class Base {
163163

164164
module: {
165165
strictExportPresence: true,
166-
rules: [{ parser: { requireEnsure: false } }, ...this.loaders.values()]
166+
rules: this.loaders.values()
167167
},
168168

169169
plugins: this.plugins.values(),

0 commit comments

Comments
 (0)