Skip to content

Restore colors when TERM is unset #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaelfranca merged 1 commit into from
Jan 27, 2020
Merged

Restore colors when TERM is unset #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/thor/shell/color.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def can_display_colors?
end

def are_colors_supported?
stdout.tty? && ![nil, "dumb"].include?(ENV["TERM"])
stdout.tty? && ENV["TERM"] != "dumb"
end

def are_colors_disabled?
Expand Down
6 changes: 0 additions & 6 deletions spec/shell/color_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,6 @@ def shell
expect(colorless).to eq("hi!")
end

it "does nothing when the TERM environment variable is not set" do
allow(ENV).to receive(:[]).with("TERM").and_return(nil)
colorless = shell.set_color "hi!", :white
expect(colorless).to eq("hi!")
end

it "does nothing when the NO_COLOR environment variable is set" do
allow(ENV).to receive(:[]).with("NO_COLOR").and_return("")
allow($stdout).to receive(:tty?).and_return(true)
Expand Down