Fix TypeError when no config given and warn if file unchanged #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enigmatt-pl
changed the title
Member
|
Thank you for the pull request. I believe if none of Can you change the code and tests to do that? #665 seems to be a different problem since |
enigmatt-pl
changed the title
enigmatt-pl
changed the title
Author
|
Ready @rafaelfranca 😃 |
rafaelfranca
reviewed
Oct 9, 2019
If no :before nor :after parameter was supplied, Thor now decides to append the data after the last piece of information within the file. In addition, a constant Hash with warnings has been added. If the file is unchanged because the flag value couldn't be found, Thor now warns the users and briefly explains what happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #571
closes #665