Fix broken Nokogiri documentation links in README.md #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvasilevski
approved these changes
Jun 9, 2025
flavorjones
requested changes
Jun 15, 2025
There was a problem hiding this comment.
@mikeygough Thanks. I would prefer if we used the official Nokogiri docs (which I maintain, in addition to this gem).
Apologies for the slow review.
mikeygough
force-pushed
the
fix-broken-nokogiri-documentation-links-in-readme
branch
from
a364285 to
720b9e6
Compare
mikeygough
force-pushed
the
fix-broken-nokogiri-documentation-links-in-readme
branch
from
720b9e6 to
305bb3b
Compare
|
No problem! Changes implemented, thanks for the review @flavorjones ! :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy,
I noticed two broken links in this gem's README.md.
This PR updates those broken links ( for
Nokogiri::XML::Node&Nokogiri::XML::NodeSet). They should now point to the correct pages on RubyDoc.info.Alternatively, we could use the Nokogiri documentation page instead of RubyDoc.info. Those links would be
Cheers,
Mikey