Skip to content

Commit 6b08834

Browse files
harsh183rafaelfranca
authored andcommitted
Fix DHH duplicate contributor entries
Map lowercase 'dhh' to 'David Heinemeier Hansson' to consolidate the 5 commits authored as 'dhh' with the main contributor profile. This fixes the issue where DHH appeared twice on contributors.rubyonrails.org: - https://contributors.rubyonrails.org/contributors/dhh/commits (5 commits) - https://contributors.rubyonrails.org/contributors/david-heinemeier-hansson/commits (4910 commits) The mapping already included 'DHH' (uppercase) but was missing 'dhh' (lowercase).
1 parent e0dc9cf commit 6b08834

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

app/models/names_manager/canonical_names.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ def self.map(canonical_name, *also_as)
359359
map 'David Easley', "easleydp\100gmail.com"
360360
map 'David Felstead', "david.felstead\100gmail.com", "dfelstead\100site5.com"
361361
map 'David François', 'David FRANCOIS', 'davout'
362-
map 'David Heinemeier Hansson', 'DHH', 'David' # for David see 5d5f0bad6e934d9d4fad7d0fa4643d04c13709a9
362+
map 'David Heinemeier Hansson', 'DHH', 'dhh', 'David' # for David see 5d5f0bad6e934d9d4fad7d0fa4643d04c13709a9
363363
map 'David Morton', "mortonda\100dgrmm.net"
364364
map 'David N. Welton', 'davidw'
365365
map 'David Raynes', 'rayners'

test/credits/canonical_names_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5163,5 +5163,9 @@ class CanonicalNamesTest < ActiveSupport::TestCase
51635163
test 'Harsh' do
51645164
assert_contributor_names '5ff38f4', 'Harsh Deep'
51655165
end
5166+
5167+
test 'dhh' do
5168+
assert_contributor_names 'dd6f3e1', 'David Heinemeier Hansson'
5169+
end
51665170
end
51675171
end

0 commit comments

Comments
 (0)