Allow custom locators to override model class #203
+107
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom locators can now implement a model_class(gid) method to control how the model class is derived from the GID. This enables mapping GID model names to different local classes without requiring matching class names. For backward compatibility, locators without model_class will fall back to the default constantize behavior with a deprecation warning. Recommended approach is to inherit from GlobalID::Locator::BaseLocator or GlobalID::Locator::UnscopedLocator to get default implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom locators can now implement a model_class(gid) method to control how the model class is derived from the GID. This enables mapping GID model names to different local classes without requiring matching class names.
For backward compatibility, locators without
model_classwill fall back to the default constantize behavior with a deprecation warning.Recommended approach is to inherit from
GlobalID::Locator::BaseLocatororGlobalID::Locator::UnscopedLocatorto get default implementations.This solves #80.