Add database specific string concatenation #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
|
It looks like #173 was closed, but not exactly sure why. Is it because this is not the right layer for this abstraction, or because that PR not support mysql? Thanks |
|
@rafaelfranca Does this look like something that could go into Arel? thanks |
|
Yes. It makes sense. Thank you for the pull request. |
rafaelfranca
added a commit
that referenced
this pull request
Jan 6, 2016
Add database specific string concatenation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All
String concatenation is database specific.
Postgres (and ANSI SQL) supports
column1 || column2, but databases like mysql useconcat(column1, column2).This PR introduces string concatenation to Arel to abstract this nuance. e.g.:
table[:name].concat(other).Before this, developers needed to build database specific sql on their own.
If Arel is not the right place for this abstraction, do you have any suggestions on how to abstract this in my own app?
Thanks,
Keenan
/cc @Fryguy @matthewd (and of course @tenderlove ) This is for ancestry, but I feel we want something similar in our spot as well.