Skip to content

Commit 0d56501

Browse files
author
Bart de Water
committed
Remove Appraisal for handcrafted Gemfiles, determine Nokogiri dependency at runtime for Rails versions that can run older Rubies
f067b34 is an incorrect solution, Ruby 2.4.1 and Rails 4.2 is a valid combo and to have no deprecation warnings that combination requires Nokogiri >= 1.7.
1 parent 3882eca commit 0d56501

File tree

6 files changed

+0
-25
lines changed

6 files changed

+0
-25
lines changed

Appraisals

Lines changed: 0 additions & 20 deletions
This file was deleted.

gemfiles/rails_4.0.gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@ source "https://rubygems.org"
55
gem "actionpack", "~> 4.0.0"
66
gem "activerecord", "~> 4.0.0"
77
gem "railties", "~> 4.0.0"
8-
gem "nokogiri", "~> 1.6.0"
98

109
gemspec :path => "../"

gemfiles/rails_4.1.gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@ source "https://rubygems.org"
55
gem "actionpack", "~> 4.1.0"
66
gem "activerecord", "~> 4.1.0"
77
gem "railties", "~> 4.1.0"
8-
gem "nokogiri", "~> 1.6.0"
98

109
gemspec :path => "../"

gemfiles/rails_4.2.gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@ source "https://rubygems.org"
55
gem "actionpack", "~> 4.2.0"
66
gem "activerecord", "~> 4.2.0"
77
gem "railties", "~> 4.2.0"
8-
gem "nokogiri", "~> 1.6.0"
98

109
gemspec :path => "../"

gemfiles/rails_5.0.gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@ source "https://rubygems.org"
55
gem "actionpack", "~> 5.0.0"
66
gem "activerecord", "~> 5.0.0"
77
gem "railties", "~> 5.0.0"
8-
gem "nokogiri", "~> 1.7.0"
98

109
gemspec :path => "../"

gemfiles/rails_5.1.gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@ source "https://rubygems.org"
55
gem "actionpack", "~> 5.1.0"
66
gem "activerecord", "~> 5.1.0"
77
gem "railties", "~> 5.1.0"
8-
gem "nokogiri", "~> 1.7.0"
98

109
gemspec :path => "../"

0 commit comments

Comments
 (0)