Skip to content

Conversation

justinclift
Copy link
Contributor

Some typos jumped out at me while skimming. 😉

Some typos jumped out at me while skimming. 😉
@justinclift
Copy link
Contributor Author

Also noticed what kind of seems like mismatching TDS version default information in the README (bitrot?), but I didn't investigate further:

Below is a list of the data types we support when using the 7.4 TDS protocol version.

TDS version. Defaults to "7.3".

If the default is now something other than 7.3, then the above line might need to be updated. 😄

@andyundso
Copy link
Member

you're correct, this should be 7.3 instead of 7.4. if you have the chance to correct this in your PR as well, that would be nice.

@justinclift
Copy link
Contributor Author

Sure, done. 😄

Note that the follow up typo fix was done as a separate commit, so this PR will probably need squashing if/when merged. 😄

@andyundso andyundso merged commit 0737149 into rails-sqlserver:master Sep 8, 2025
221 of 224 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants