Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possibility of not modifying instance variables for resetting sequence names #91

Closed
rpbaltazar opened this issue Jul 12, 2020 · 0 comments
Labels
enhancement New feature or request stale

Comments

@rpbaltazar
Copy link
Contributor

reset_sequence_names method implementation for postgresql adapter removes the variable sequence_name if it exists. this has the following note:

# sequence_name contains the schema, so it must be reset after switch
# There is `reset_sequence_name`, but that method actually goes to the database
# to find out the new name. Therefore, we do this hack to only unset the name,
# and it will be dynamically found the next time it is needed

but as the name indicates it, it feels hackish and seems to have caused some random issues as described in #81

This logic should be revisited and improved if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants