Adding fetch_multi to Cache Strategy

[joaomdmoura]

As pointed out by @thibaudgg on my last PR #810 (Adding Fragment Cache to AMS), fetch_multi would be a great optimisation to the new cache implementation (#693).

One feature of the new implementation is the individual cache strategy. It enables your application to re-use the cache in different responses.

Ex. It can re-use an object cached from a index method response, on a show method response. The opposite is also true.

AMS will also retrieve this cached objects individually, and that's when fetch_multi comes in. It improves performance by retrieving multiple cache keys for a collection in a single go.

Despite of a simple improvement, it isn't easy. It will change how the Adapter fetches cache and how it integrates with FragmentCache

I'm planning to work on this, but would like to hear some thoughts :)

[thibaudgg]

Great news, thanks @joaomdmoura!
I'm not familiar with the implementation, but IMHO adding fetch_multi seems really mandatory for production.
It would works and reuse the object cached for associations as well right?

[joaomdmoura]

@thibaudgg I don't think it's mandatory (we are already conducting some production tests) but yeah, it's definitively a great optimisation! Really useful!
In this case it wouldn't be necessary in cached associations. The associations doesn't generate an individual cache for the associated object. It's cached along the original requested object.

[thibaudgg]

@joaomdmoura you're right "mandatory" is too strong, but definitely great to have.
My point with associations is to have each object cached separately, so for example if you load & cache a post with comments and you want to load just a comment after it should already be cached.
I guess that @kurko's comment goes in that direction.

[joaomdmoura]

Yeah @thibaudgg we discussed it yesterday and we'll move forward with this strategy! 😄 I'm not sure if fetch_multi will be used to associations yet, but they will be cache separately

[thibaudgg]

Great, keep up the good work!

[bf4]

The related thoughtbot article is pretty good, even though for 0.8 https://robots.thoughtbot.com/fast-json-apis-in-rails-with-key-based-caches-and

[philipgiuliani]

Already any updates on this? I noticed that most of the time my controller spends to talk with redis for fetching the records. Would be a great improvement!

[bf4]

Wanna help?

B mobile phone

On Nov 3, 2015, at 2:12 AM, Philip Giuliani notifications@github.com wrote:

Already any updates on this? I noticed that most of the time my controller spends to talk with redis for fetching the records. Would be a great improvement!

—
Reply to this email directly or view it on GitHub.