--wip--

Author: Артём Большаков

lib/active_model/serializer/association.rb

@@ -1,5 +1,7 @@
 module ActiveModel
   class Serializer
+    # This class hold all information about serializer's association.
+    #
     Association = Struct.new(:name, :serializer, :options)
   end
 end

lib/active_model/serializer/associations.rb

@@ -22,14 +22,24 @@ def inherited(base)
           base._reflections = self._reflections.try(:dup) || []
         end
 
+        # alias_method :reflections, :_reflections
+
         # Defines an association in the object should be rendered.
         #
         # The serializer object should implement the association name
         # as a method which should return an array when invoked. If a method
         # with the association name does not exist, the association name is
         # dispatched to the serialized object.
-        def has_many(*attrs)
-          associate attrs do |name, options|
+        #
+        # @param [Array<Symbol>] names association names
+        # @param [Hash<Symbol,Object>] options for given association
+        #
+        # @example
+        #  has_many :comments, serializer: CommentSummarySerializer
+        #  has_many :commits, authors
+        #
+        def has_many(*names, **options)
+          associate names do |name|
             HasManyReflection.new(name, options)
           end
         end
@@ -40,8 +50,8 @@ def has_many(*attrs)
         # as a method which should return an object when invoked. If a method
         # with the association name does not exist, the association name is
         # dispatched to the serialized object.
-        def belongs_to(*attrs)
-          associate attrs do |name, options|
+        def belongs_to(*names, **options)
+          associate names do |name|
             BelongsToReflection.new(name, options)
           end
         end
@@ -52,26 +62,25 @@ def belongs_to(*attrs)
         # as a method which should return an object when invoked. If a method
         # with the association name does not exist, the association name is
         # dispatched to the serialized object.
-        def has_one(*attrs)
-          associate attrs do |name, options|
+        def has_one(*names, **options)
+          associate names do |name|
             HasOneReflection.new(name, options)
           end
         end
 
         private
 
-        def associate(attrs, &block) #:nodoc:
-          options = attrs.extract_options!
+        def associate(names, &block) #:nodoc:
           self._reflections = _reflections.dup
 
-          attrs.each do |name|
+          names.each do |name|
             unless method_defined?(name)
               define_method name do
                 object.send name
               end
             end
 
-            self._reflections << block.call(name, options)
+            self._reflections << block.call(name)
           end
         end
       end

lib/active_model/serializer/reflection.rb

@@ -2,6 +2,25 @@ module ActiveModel
   class Serializer
     # Holds all the meta-data about an association as it was specified in the
     # ActiveModel::Serializer class.
-    Reflection = Struct.new(:name, :options)
+    #
+    # @example
+    #  class PostSerializer < ActiveModel::Serializer
+    #     has_one :author, serializer: AuthorSerializer
+    #     has_many :comments
+    #  end
+    #
+    #  PostSerializer.reflections #=>
+    #    # [
+    #    #   HasOneReflection.new(:author, serializer: AuthorSerializer),
+    #    #   HasManyReflection.new(:comments)
+    #    # ]
+    #
+    # So you can inspect reflections in your Adapters.
+    #
+    Reflection = Struct.new(:name, :options) do
+      def self.build(macro, *names)
+        macro
+      end
+    end
   end
 end

test/serializers/associations_test.rb

@@ -84,8 +84,6 @@ def test_serializer_options_are_passed_into_associations_serializers
           serializer = association.serializer
 
           if name == :comments
-            puts serializer.first
-
             assert serializer.first.custom_options[:custom_options]
           end
         end