You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But from what I recently observed, web3py does not return None in error cases (or at least not in all of them), but a ValueError. This requires changing the pattern to
Devise a pattern to handle all relevant cases (other errors might cause other exceptions, or still return None)
Implement pattern in all proxies
Alternatively, we could take advantage of ethereum/web3.py#941 and use the returned revert messages. This could make large parts of the error handling code unnecessary. But for that to work well, we need to add revert messages to the contracts first.
The text was updated successfully, but these errors were encountered:
Our proxies use the pattern
But from what I recently observed, web3py does not return None in error cases (or at least not in all of them), but a ValueError. This requires changing the pattern to
Alternatively, we could take advantage of ethereum/web3.py#941 and use the returned revert messages. This could make large parts of the error handling code unnecessary. But for that to work well, we need to add revert messages to the contracts first.
The text was updated successfully, but these errors were encountered: