improve GCS perf: Change resource limit to request (apple#851)

samos123 · web-flow · commit 4858070877ed · 2025-01-17T21:54:05.000Z
diff --git a/axlearn/cloud/gcp/job.py b/axlearn/cloud/gcp/job.py
@@ -629,9 +629,9 @@ def _build_pod(self) -> Nested[Any]:
             annotations.update(
                 {
                     "gke-gcsfuse/volumes": "true",
-                    "gke-gcsfuse/cpu-limit": cfg.gcsfuse_mount.cpu,
-                    "gke-gcsfuse/memory-limit": cfg.gcsfuse_mount.memory,
-                    "gke-gcsfuse/ephemeral-storage-limit": cfg.gcsfuse_mount.ephemeral_gb,
+                    "gke-gcsfuse/cpu-request": cfg.gcsfuse_mount.cpu,
+                    "gke-gcsfuse/memory-request": cfg.gcsfuse_mount.memory,
+                    "gke-gcsfuse/ephemeral-storage-request": cfg.gcsfuse_mount.ephemeral_gb,
                 }
             )
             # Parse GCSFuseMount path into bucket, prefix.

Original file line number	Diff line number	Diff line change
`@@ -629,9 +629,9 @@ def _build_pod(self) -> Nested[Any]:`
`629`	`629`	`annotations.update(`
`630`	`630`	`{`
`631`	`631`	`"gke-gcsfuse/volumes": "true",`
`632`		`- "gke-gcsfuse/cpu-limit": cfg.gcsfuse_mount.cpu,`
`633`		`- "gke-gcsfuse/memory-limit": cfg.gcsfuse_mount.memory,`
`634`		`- "gke-gcsfuse/ephemeral-storage-limit": cfg.gcsfuse_mount.ephemeral_gb,`
	`632`	`+ "gke-gcsfuse/cpu-request": cfg.gcsfuse_mount.cpu,`
	`633`	`+ "gke-gcsfuse/memory-request": cfg.gcsfuse_mount.memory,`
	`634`	`+ "gke-gcsfuse/ephemeral-storage-request": cfg.gcsfuse_mount.ephemeral_gb,`
`635`	`635`	`}`
`636`	`636`	`)`
`637`	`637`	`# Parse GCSFuseMount path into bucket, prefix.`