Skip to content

Commit 495d445

Browse files
committed
fix: merge conflicts and compilation errors
1 parent a224e88 commit 495d445

File tree

4 files changed

+6
-63
lines changed

4 files changed

+6
-63
lines changed

api/api/versions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{
44
"version": "v1",
55
"status": "active",
6-
"release_date": "2025-12-06T16:23:50.657646+05:30",
6+
"release_date": "2025-12-06T19:40:52.670434+05:30",
77
"end_of_life": "0001-01-01T00:00:00Z",
88
"changes": [
99
"Initial API version"

api/doc/openapi.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

api/internal/features/github-connector/service/update_connector.go

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -68,41 +68,6 @@ func (c *GithubConnectorService) UpdateGithubConnectorRequest(InstallationID str
6868
}
6969
}
7070

71-
var connectorToUpdate *shared_types.GithubConnector
72-
73-
// If ConnectorID is provided, find and update that specific connector
74-
if ConnectorID != "" {
75-
// Validate UUID format
76-
if _, err := uuid.Parse(ConnectorID); err != nil {
77-
return fmt.Errorf("invalid connector_id format: %v", err)
78-
}
79-
80-
// Find the connector with matching ID
81-
for i := range connectors {
82-
if connectors[i].ID.String() == ConnectorID {
83-
connectorToUpdate = &connectors[i]
84-
break
85-
}
86-
}
87-
88-
if connectorToUpdate == nil {
89-
return fmt.Errorf("connector with id %s not found", ConnectorID)
90-
}
91-
} else {
92-
// Find connector without installation_id (newly created connector)
93-
for i := range connectors {
94-
if connectors[i].InstallationID == "" || strings.TrimSpace(connectors[i].InstallationID) == "" {
95-
connectorToUpdate = &connectors[i]
96-
break
97-
}
98-
}
99-
100-
// If no connector without installation_id found, use first connector
101-
if connectorToUpdate == nil {
102-
connectorToUpdate = &connectors[0]
103-
}
104-
}
105-
10671
err = c.storage.UpdateConnector(connectorToUpdate.ID.String(), InstallationID)
10772
if err != nil {
10873
return err

view/app/self-host/components/github-connector/github-connector-settings-modal.tsx

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ const ConnectorItem: React.FC<ConnectorItemProps> = ({
4545

4646
const handleDelete = (e: React.MouseEvent) => {
4747
e.stopPropagation();
48-
const handleDelete = () => {
4948
setShowDeleteDialog(true);
5049
};
5150

@@ -96,26 +95,6 @@ const ConnectorItem: React.FC<ConnectorItemProps> = ({
9695
</div>
9796
</div>
9897
<div className="flex items-center gap-2 shrink-0" onClick={(e) => e.stopPropagation()}>
99-
<div className="flex items-center gap-2 shrink-0">
100-
{!isActive && (
101-
<Button
102-
variant="outline"
103-
size="sm"
104-
onClick={() => onSetActive(connector.id)}
105-
disabled={isDeleting || isUpdating}
106-
>
107-
{t('selfHost.connectorSettings.actions.switch.label' as any)}
108-
</Button>
109-
)}
110-
<Button
111-
variant="outline"
112-
size="sm"
113-
onClick={() => onReset(connector.id)}
114-
disabled={isDeleting || isUpdating}
115-
title={t('selfHost.connectorSettings.actions.reset.label' as any)}
116-
>
117-
<RefreshCw size={16} />
118-
</Button>
11998
<Button
12099
variant="destructive"
121100
size="sm"
@@ -132,10 +111,9 @@ const ConnectorItem: React.FC<ConnectorItemProps> = ({
132111
open={showDeleteDialog}
133112
onOpenChange={setShowDeleteDialog}
134113
title={t('selfHost.connectorSettings.actions.delete.dialog.title' as any)}
135-
description={t('selfHost.connectorSettings.actions.delete.dialog.description' as any).replace(
136-
'{name}',
137-
connector.name || connector.slug
138-
)}
114+
description={t(
115+
'selfHost.connectorSettings.actions.delete.dialog.description' as any
116+
).replace('{name}', connector.name || connector.slug)}
139117
onConfirm={confirmDelete}
140118
confirmText={
141119
isDeleting
@@ -237,6 +215,7 @@ const GitHubConnectorSettingsModal: React.FC<GitHubConnectorSettingsModalProps>
237215
isActive={connector.id === activeConnectorId}
238216
onSetActive={handleSetActiveConnector}
239217
onDelete={handleDeleteConnector}
218+
onReset={handleResetConnector}
240219
isDeleting={isDeleting === connector.id}
241220
isUpdating={isUpdating === connector.id}
242221
/>
@@ -302,4 +281,3 @@ const GitHubConnectorSettingsModal: React.FC<GitHubConnectorSettingsModalProps>
302281
};
303282

304283
export default GitHubConnectorSettingsModal;
305-

0 commit comments

Comments
 (0)