-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use DataAPI.metadata instead of redefining it #707
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
==========================================
+ Coverage 83.86% 83.87% +0.01%
==========================================
Files 46 46
Lines 4257 4267 +10
==========================================
+ Hits 3570 3579 +9
- Misses 687 688 +1 ☔ View full report in Codecov by Sentry. |
May need to check we don't have |
We have And these methods are going to be a piracy problem: [2] metadata(::Tuple{})
@ DimensionalData.Dimensions ~/.julia/dev/DimensionalData/src/Dimensions/dimension.jl:232
[15] metadata(ds::Tuple, I)
@ DimensionalData.Dimensions ~/.julia/dev/DimensionalData/src/Dimensions/dimension.jl:234
[16] metadata(ds::Tuple, i1, I...)
@ DimensionalData.Dimensions ~/.julia/dev/DimensionalData/src/Dimensions/dimension.jl:233
[17] metadata(ds::Tuple)
@ DimensionalData.Dimensions ~/.julia/dev/DimensionalData/src/Dimensions/dimension.jl:231
[18] metadata(x)
@ ~/.julia/dev/DimensionalData/src/Lookups/metadata.jl:107 I guess we can make all the The untyped case may be a problem too, we can try deleting it and see what breaks. |
Thanks - will take a look today! |
so that method is at least open... |
Ah damn, I just realized that the way that DD handles metadata ( |
|
From discussion: we could instead forward DataAPI.metadata to DimensionalData.metadata so at least they both work. |
Actually thinking about just culling all the DD metadata handling so we use a Dict or NamedTuple or It will be annoying to check keys but its worth it to use |
Fix #706 by explicitly importing DataAPI.metadata.