Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bounds handling for grids, add methods for cat, extrema etc #24

Merged
merged 4 commits into from
Dec 16, 2019

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Dec 16, 2019

Accidentally rebased these into one commit.

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #24 into master will increase coverage by 5.29%.
The diff coverage is 82.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   72.19%   77.49%   +5.29%     
==========================================
  Files          11       11              
  Lines         464      511      +47     
==========================================
+ Hits          335      396      +61     
+ Misses        129      115      -14
Impacted Files Coverage Δ
src/DimensionalData.jl 100% <ø> (ø) ⬆️
src/selector.jl 87.93% <100%> (+7.22%) ⬆️
src/dimension.jl 90.9% <100%> (+18.18%) ⬆️
src/grid.jl 80% <75%> (-0.36%) ⬇️
src/methods.jl 80.76% <77.77%> (-2.21%) ⬇️
src/primitives.jl 83.22% <91.17%> (+6.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0bacb...9675832. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants