Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto atol for At #145

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Remove auto atol for At #145

merged 2 commits into from
Aug 18, 2020

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Aug 17, 2020

This allows At to be the default action for all non Int values.

If the dimension holds a Val{(1.0, 1.1, 1.2)} or similar it can be indexed with no runtime overhead. This currently doesn't work for Number because atol/rtol values are set automatically.

It you need them, set them manually as keyword args:

At(x; atol=1e10)

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #145 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   84.47%   84.40%   -0.07%     
==========================================
  Files          12       12              
  Lines        1011     1007       -4     
==========================================
- Hits          854      850       -4     
  Misses        157      157              
Impacted Files Coverage Δ
src/selector.jl 77.22% <ø> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0476efc...1556762. Read the comment docs.

@rafaqz rafaqz merged commit 72bfbf9 into master Aug 18, 2020
@rafaqz rafaqz deleted the noatol branch September 15, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants