Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rebuild with Setfield.jl #10

Closed
rafaqz opened this issue Oct 13, 2019 · 0 comments
Closed

Replace rebuild with Setfield.jl #10

rafaqz opened this issue Oct 13, 2019 · 0 comments

Comments

@rafaqz
Copy link
Owner

rafaqz commented Oct 13, 2019 •
edited
Loading

rebuild should use Setfield.jl, so only constructorof needs to be defined for new array types (or use the default) instead of needing a rebuild.

Except this assumes that field names will be the same in new implementations. Which is bad. There might not even be e.g. a refdims field.
@rafaqz rafaqz closed this as completed Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rafaqz