Skip to content

Commit 0fd7a0c

Browse files
Fix Dialog demo labelling (#421)
* Fix Dialog demo labelling Fixes #420 * Update 0.1.7.mdx
1 parent 3f58079 commit 0fd7a0c

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

components/demos/Dialog.jsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,13 +182,11 @@ const DialogDemo = () => (
182182
</Fieldset>
183183
<Flex css={{ marginTop: 25, justifyContent: 'flex-end' }}>
184184
<DialogClose asChild>
185-
<Button aria-label="Close" variant="green">
186-
Save changes
187-
</Button>
185+
<Button variant="green">Save changes</Button>
188186
</DialogClose>
189187
</Flex>
190188
<DialogClose asChild>
191-
<IconButton>
189+
<IconButton aria-label="Close">
192190
<Cross2Icon />
193191
</IconButton>
194192
</DialogClose>

data/primitives/components/dialog/0.1.7.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ export const DialogContent = React.forwardRef(
486486
<DialogPrimitive.Overlay />
487487
<DialogPrimitive.Content {...props} ref={forwardedRef}>
488488
{children}
489-
<DialogPrimitive.Close>
489+
<DialogPrimitive.Close aria-label="Close">
490490
<Cross1Icon />
491491
</DialogPrimitive.Close>
492492
</DialogPrimitive.Content>

0 commit comments

Comments
 (0)