Skip to content

Conversation

@benoitgrelard
Copy link
Contributor

Closes #1289

Note: I also renamed data-state="active|inactive" to data-state="checked|unchecked" in Select to avoid confusion and bring inline with menus.

@benoitgrelard benoitgrelard requested a review from andy-hook as a code owner May 11, 2022 11:05
@benoitgrelard benoitgrelard changed the title [Menu][Select] Add data-active attribute [Menu][Select] Add data-highlighted attribute May 11, 2022
@benoitgrelard benoitgrelard merged commit 30dd35b into main May 11, 2022
@benoitgrelard benoitgrelard deleted the 1289-data-active branch May 11, 2022 14:32
luisorbaiceta pushed a commit to luisorbaiceta/primitives that referenced this pull request Jul 21, 2022
* [Menu][Select] Add `data-active` attribute

Closes radix-ui#1289

* Rename active to highlighted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Menu] Introduce new data-active state attribute

3 participants