[Tabs] Add animation support for content #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hook
commented
Apr 27, 2022
andy-hook
force-pushed
the
tabs-presence
branch
from
eece743 to
f196472
Compare
Contributor
|
The chromatic diff is weird: First time I ever see everything moved a tiny bit, there must be a reason 🤔 |
Contributor
Author
I'll check it out, this branch is quite a bit behind now so needs a refresh anyway |
andy-hook
commented
May 20, 2022
benoitgrelard
approved these changes
May 20, 2022
This was referenced May 23, 2022
luisorbaiceta
pushed a commit
to luisorbaiceta/primitives
that referenced
this pull request
Jul 21, 2022
* Add presence to tabs * Versions * Add deps * Move story style dec * Simplify animation prevention * Story code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #860
Very similar to our approach for
Collapsiblewith a couple of modifications (we don't need to measure in this case). I assume we have historic / a11y reasons for controlling render ofchildrenrather than on wrapping element, hence my use of the render prop in this instance.