Update k3d create command in workflow #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
rynowak
approved these changes
Aug 11, 2024
ytimocin
approved these changes
Aug 12, 2024
kachawla
reviewed
Aug 12, 2024
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
rynowak
approved these changes
Aug 13, 2024
kachawla
approved these changes
Aug 13, 2024
vishwahiremat
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Update k3d create command in workflow Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> * Add comment to k3d setup Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> --------- Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the workflow command used for creating a k3d cluster by adding a parameter to
k3d cluster createto disable the default load balancer. The default load balancer was conflicting with the load balancer deployed by Radius. See the issue reference linked below for details.Note:
traefik@server:0was changed totraefik@server:*to indicate that all instances should be affected, not just the one at index zero.Issue reference
Fixes: radius-project/radius#7637