Skip to content

Conversation

lakshmimsft
Copy link
Contributor

@lakshmimsft lakshmimsft commented Jan 28, 2025

Description

The PR adds a check to the cleanup process for long-running cluster, so we skip the deletion of builtin resources when a new build is not generated.

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #8357

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 28, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 71ecbb2
Unique ID func53afe58927
Image tag pr-func53afe58927
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func53afe58927
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func53afe58927
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func53afe58927
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func53afe58927
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func53afe58927
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.94%. Comparing base (835abb0) to head (71ecbb2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8358   +/-   ##
=======================================
  Coverage   59.94%   59.94%           
=======================================
  Files         596      596           
  Lines       40432    40432           
=======================================
  Hits        24238    24238           
  Misses      14367    14367           
  Partials     1827     1827           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lakshmimsft lakshmimsft merged commit 5d5a634 into radius-project:main Jan 29, 2025
29 checks passed
@lakshmimsft lakshmimsft deleted the lakshmimsft/addchecklongrunningtest branch July 21, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long Running tests failing at Configuring Radius test workspace
2 participants