Implementation of Dapr Building Block: Configuration Store #7906

SoTrx · 2024-09-09T14:23:51Z

Description

Hey,

This PR adds support for Dapr Configuration Building block

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #7889

codecov · 2024-09-09T14:46:29Z

Codecov Report

Attention: Patch coverage is 66.66667% with 67 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (a5e97c3) to head (e655e73).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...daprrp/processors/configurationstores/processor.go	45.45%	30 Missing and 6 partials ⚠️
pkg/daprrp/datamodel/daprconfigurationstore.go	0.00%	12 Missing ⚠️
pkg/daprrp/setup/setup.go	43.75%	8 Missing and 1 partial ⚠️
...g/corerp/backend/deployment/deploymentprocessor.go	0.00%	5 Missing ⚠️
.../v20231001preview/configurationstore_conversion.go	97.50%	1 Missing and 1 partial ⚠️
...atamodel/converter/configurationstore_converter.go	90.00%	1 Missing and 1 partial ⚠️
pkg/rp/portableresources/portableresources.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7906      +/-   ##
==========================================
+ Coverage   60.97%   61.08%   +0.11%     
==========================================
  Files         527      531       +4     
  Lines       27860    28061     +201     
==========================================
+ Hits        16988    17142     +154     
- Misses       9378     9425      +47     
  Partials     1494     1494

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-09-09T17:36:39Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	SoTrx/radius
Commit ref	`346c150`
Unique ID	funcd8e1b09af9
Image tag	pr-funcd8e1b09af9

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd8e1b09af9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd8e1b09af9
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd8e1b09af9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd8e1b09af9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin

Looking great so far! Thanks for this addition!

pkg/daprrp/api/v20231001preview/configurationstore_conversion.go

pkg/daprrp/api/v20231001preview/configurationstore_conversion_test.go

pkg/daprrp/datamodel/daprconfigurationstore.go

pkg/daprrp/frontend/controller/types.go

pkg/daprrp/processors/configurationstores/processor_test.go

test/magpiego/server.go

radius-functional-tests · 2024-09-10T17:22:39Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	SoTrx/radius
Commit ref	`f380b23`
Unique ID	funcc8e7f711ee
Image tag	pr-funcc8e7f711ee

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc8e7f711ee
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc8e7f711ee
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc8e7f711ee
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc8e7f711ee
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin

Left a nit

pkg/portableresources/handlers/util.go

lakshmimsft · 2024-09-11T15:41:51Z

This is truly superb! Thank you @SoTrx for your contribution! 🔥

I have two questions.
@SoTrx , this is a new addition to Radius and we would need documentation on it in the docs repo. https://github.com/radius-project/docs so it goes out as a complete feature. (Samples is also a part of this but docs is needed at the very least.) Do you think you want to try submit a PR for it?

One question to the team @ytimocin , @rynowak related to this.
If I'm reading this right, https://github.com/dapr/dapr/blob/9591e5778c4e03587acabe35744770881a86c35f/charts/dapr/crds/components.yaml#L83-L86
, then metadata, version and type are required fields for all components. Is there a reason we have them as optional at our end?

radius/typespec/Applications.Dapr/common.tsp

Lines 27 to 35 in 96fb582

    
           @doc("The metadata for Dapr resource which must match the values specified in Dapr component spec") 
        
           metadata?: Record<MetadataValue>; 
        
           #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-duplicate-property" 
        
           @doc("Dapr component type which must matches the format used by Dapr Kubernetes configuration format") 
        
           type?: string; 
        
           @doc("Dapr component version") 
        
           version?: string;

Was it intentional, say, for future flexibility or do we want to update it since it applies to all components. I can create a separate issue for it .

radius-functional-tests · 2024-09-11T16:10:04Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	SoTrx/radius
Commit ref	`4d2c0df`
Unique ID	func30abc5c80e
Image tag	pr-func30abc5c80e

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func30abc5c80e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func30abc5c80e
controller test image location: ghcr.io/radius-project/dev/controller:pr-func30abc5c80e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func30abc5c80e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

kachawla

Thank you @SoTrx! Can you please summarize proposed schema updates and user experience in the corresponding GitHub issue #7889?

SoTrx · 2024-09-12T15:07:09Z

@lakshmimsft I'll try to make a PR for the documentation.

@kachawla No problem

kachawla · 2024-09-12T16:10:04Z

@lakshmimsft I'll try to make a PR for the documentation.

@kachawla No problem

Thank you, @SoTrx

Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

…test.go Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

…tionStore Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

…tionStore in functional tests Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

…tionStore again Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

radius-functional-tests · 2024-09-18T17:42:15Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	SoTrx/radius
Commit ref	`e655e73`
Unique ID	funcd8f26c73e3
Image tag	pr-funcd8f26c73e3

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd8f26c73e3
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd8f26c73e3
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd8f26c73e3
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd8f26c73e3
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

lakshmimsft · 2024-09-18T18:07:54Z

Thanks for your contribution again @SoTrx !!

SoTrx requested review from a team as code owners September 9, 2024 14:23

SoTrx temporarily deployed to functional-tests September 9, 2024 17:33 — with GitHub Actions Inactive

ytimocin reviewed Sep 9, 2024

View reviewed changes

SoTrx force-pushed the feat_dapr-configuration branch from 39e472f to edc3a78 Compare September 10, 2024 10:52

SoTrx temporarily deployed to functional-tests September 10, 2024 17:21 — with GitHub Actions Inactive

ytimocin reviewed Sep 10, 2024

View reviewed changes

pkg/portableresources/handlers/util.go Outdated Show resolved Hide resolved

SoTrx force-pushed the feat_dapr-configuration branch from 3a3ea2f to 16daeb2 Compare September 11, 2024 14:37

SoTrx temporarily deployed to functional-tests September 11, 2024 16:09 — with GitHub Actions Inactive

kachawla reviewed Sep 11, 2024

View reviewed changes

lakshmimsft mentioned this pull request Sep 12, 2024

Update to DaprResourceProperties #7919

Open

1 task

SoTrx and others added 12 commits September 18, 2024 10:32

feat(daprrp): Support for Configuration Building Block

932702a

Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

test(pubsub): fix minor error in Dapr PubSub broker test

b8c0a64

Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

style(typespec): Linting

1a5dbec

Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/api/v20231001preview/configurationstore_conversion.go

3bdec76

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/api/v20231001preview/configurationstore_conversion_…

e095aa3

…test.go Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/api/v20231001preview/configurationstore_conversion_…

cbabbc7

…test.go Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/frontend/controller/types.go

d772c6e

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/datamodel/daprconfigurationstore.go

78250b7

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/datamodel/daprconfigurationstore.go

d0154fd

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/datamodel/daprconfigurationstore.go

fcb6814

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/datamodel/daprconfigurationstore.go

0f54526

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/daprrp/datamodel/daprconfigurationstore.go

bb80dc1

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

SoTrx and others added 6 commits September 18, 2024 10:32

style: adjust spacing and rename variables for consistency

60282a8

Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

test: Updating Dapr conflict prompt with new building block Configura…

46bce26

…tionStore Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

test: Updating Dapr conflict prompt with new building block Configura…

b53c88d

…tionStore in functional tests Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

Update pkg/portableresources/handlers/util.go

31aebcc

Co-authored-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

test: Updating Dapr conflict prompt with new building block Configura…

726a587

…tionStore again Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

test: Updating Dapr conflict prompt with new building block Configura…

e655e73

…tionStore again Signed-off-by: SoTrx <11771975+SoTrx@users.noreply.github.com>

lakshmimsft force-pushed the feat_dapr-configuration branch from 4d2c0df to e655e73 Compare September 18, 2024 17:33

lakshmimsft temporarily deployed to functional-tests September 18, 2024 17:41 — with GitHub Actions Inactive

lakshmimsft approved these changes Sep 18, 2024

View reviewed changes

lakshmimsft merged commit a17f9cf into radius-project:main Sep 18, 2024
28 checks passed

lakshmimsft mentioned this pull request Sep 26, 2024

Add Applications.Dapr/configurationStores local-dev recipe radius-project/recipes#75

Merged

willtsai mentioned this pull request Oct 10, 2024

Release v0.39.0 #7987

Merged

6 tasks

nicolejms self-assigned this Oct 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of Dapr Building Block: Configuration Store #7906

Implementation of Dapr Building Block: Configuration Store #7906

SoTrx commented Sep 9, 2024

codecov bot commented Sep 9, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 9, 2024 •

edited

Loading

ytimocin left a comment

radius-functional-tests bot commented Sep 10, 2024 •

edited

Loading

ytimocin left a comment

lakshmimsft commented Sep 11, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 11, 2024 •

edited

Loading

kachawla left a comment

SoTrx commented Sep 12, 2024

kachawla commented Sep 12, 2024

radius-functional-tests bot commented Sep 18, 2024 •

edited

Loading

lakshmimsft commented Sep 18, 2024

Implementation of Dapr Building Block: Configuration Store #7906

Implementation of Dapr Building Block: Configuration Store #7906

Conversation

SoTrx commented Sep 9, 2024

Description

Type of change

codecov bot commented Sep 9, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Sep 9, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Sep 10, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin left a comment

Choose a reason for hiding this comment

lakshmimsft commented Sep 11, 2024 • edited Loading

radius-functional-tests bot commented Sep 11, 2024 • edited Loading

Radius functional test overview

Test Status

kachawla left a comment

Choose a reason for hiding this comment

SoTrx commented Sep 12, 2024

kachawla commented Sep 12, 2024

radius-functional-tests bot commented Sep 18, 2024 • edited Loading

Radius functional test overview

Test Status

lakshmimsft commented Sep 18, 2024

codecov bot commented Sep 9, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 9, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 10, 2024 •

edited

Loading

lakshmimsft commented Sep 11, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 11, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 18, 2024 •

edited

Loading