Adding Kubernetes native secrets to secret stores #7744

superbeeny · 2024-07-18T18:17:05Z

Description

Adding secret store capabilities to reference kubernetes secrets natively

Type of change

This pull request adds or changes features of Radius and has an approved issue (Design: extend the use-cases of Applications.Core/secretStores #5520) .

Fixes: #5520

radius-functional-tests · 2024-07-18T18:18:29Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`14071b1`
Unique ID	func5643007ca6
Image tag	pr-func5643007ca6

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5643007ca6
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5643007ca6
controller test image location: ghcr.io/radius-project/dev/controller:pr-func5643007ca6
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5643007ca6
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
❌ Failed to install Radius for shared functional test. Please check the logs for more details
❌ Failed to install Radius for datastoresrp functional test. Please check the logs for more details
❌ shared functional test failed. Please check the logs for more details
❌ Failed to install Radius for samples functional test. Please check the logs for more details
❌ datastoresrp functional test failed. Please check the logs for more details
❌ Failed to install Radius for daprrp functional test. Please check the logs for more details
❌ samples functional test failed. Please check the logs for more details
❌ Failed to install Radius for msgrp functional test. Please check the logs for more details
❌ Failed to install Radius for ucp functional test. Please check the logs for more details
❌ msgrp functional test failed. Please check the logs for more details
❌ msgrp functional test cancelled. Please check the logs for more details
❌ ucp functional test cancelled. Please check the logs for more details
❌ daprrp functional test cancelled. Please check the logs for more details
❌ kubernetes functional test cancelled. Please check the logs for more details
❌ cli functional test cancelled. Please check the logs for more details

codecov · 2024-07-18T18:26:56Z

Codecov Report

Attention: Patch coverage is 85.10638% with 14 lines in your changes missing coverage. Please review.

Project coverage is 61.18%. Comparing base (96d5cf8) to head (9ebc7ab).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/corerp/renderers/container/render.go	81.13%	7 Missing and 3 partials ⚠️
...orerp/api/v20231001preview/container_conversion.go	90.24%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7744      +/-   ##
==========================================
+ Coverage   61.06%   61.18%   +0.11%     
==========================================
  Files         523      523              
  Lines       27497    27588      +91     
==========================================
+ Hits        16792    16879      +87     
- Misses       9218     9222       +4     
  Partials     1487     1487

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-07-18T18:28:40Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`f1d1aca`
Unique ID	func39bb0aa53b
Image tag	pr-func39bb0aa53b

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func39bb0aa53b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func39bb0aa53b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func39bb0aa53b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func39bb0aa53b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
❌ daprrp functional test failed. Please check the logs for more details
✅ ucp functional tests succeeded
❌ cli functional test cancelled. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details

radius-functional-tests · 2024-07-18T18:50:07Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`5f240b8`
Unique ID	funcd6ffade561
Image tag	pr-funcd6ffade561

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd6ffade561
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd6ffade561
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd6ffade561
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd6ffade561
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
❌ shared functional test cancelled. Please check the logs for more details
❌ daprrp functional test cancelled. Please check the logs for more details

radius-functional-tests · 2024-07-18T19:05:15Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`910fdde`
Unique ID	funca04f33fda5
Image tag	pr-funca04f33fda5

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca04f33fda5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca04f33fda5
controller test image location: ghcr.io/radius-project/dev/controller:pr-funca04f33fda5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca04f33fda5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting cli functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
❌ daprrp functional test failed. Please check the logs for more details
❌ cli functional test cancelled. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details
❌ shared functional test cancelled. Please check the logs for more details

rynowak · 2024-07-19T00:39:52Z

Thanks for submitting this @superbeeny ! This is a substantial feature that has been on the backlog for a long time.

I'll start reviewing the code. While we're making progress on that, a few month things we'll need to do.

Post and get signoff on a feature design spec at radius-project/design-notes. We require a design doc for API changes. @willtsai is on the hook for this.
Post and get signoff on a an engineering design doc at radius-project/design-notes. We require a design doc for API changes.
Update existing functional tests and samples to handle the breaking change.
Update docs (post-merge) to make sure they are valid.

/cc @Reshrahim as FYI

typespec/Applications.Core/containers.tsp

pkg/corerp/api/v20231001preview/container_conversion.go

pkg/corerp/renderers/container/render.go

pkg/corerp/renderers/container/render_test.go

ytimocin

This is looking great! Added some comments and asked some questions. Thanks a lot!

pkg/corerp/api/v20231001preview/container_conversion.go

pkg/corerp/datamodel/container.go

pkg/corerp/renderers/container/render.go

...tion/applications/resource-manager/Applications.Core/preview/2023-10-01-preview/openapi.json

test/functional-portable/corerp/noncloud/resources/container_test.go

typespec/Applications.Core/containers.tsp

pkg/corerp/api/v20231001preview/container_conversion.go

superbeeny · 2024-07-19T12:56:38Z

DCO not my fault ;)

superbeeny · 2024-07-19T14:43:55Z

Functional Test - https://github.com/radius-project/radius/actions/runs/9997221043/job/27633433901#step:27:216

failed with a 403 error which I don't think is related to this PR

pkg/corerp/api/v20231001preview/container_conversion.go

typespec/Applications.Core/containers.tsp

pkg/corerp/api/v20231001preview/container_conversion.go

pkg/corerp/datamodel/container.go

radius-functional-tests · 2024-08-15T17:32:13Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`d8b2413`
Unique ID	func6437ea859d
Image tag	pr-func6437ea859d

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func6437ea859d
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func6437ea859d
controller test image location: ghcr.io/radius-project/dev/controller:pr-func6437ea859d
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func6437ea859d
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
❌ Test recipe publishing failed

radius-functional-tests · 2024-08-15T17:32:13Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`9e83cdb`
Unique ID	funcc37fb0ed28
Image tag	pr-funcc37fb0ed28

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc37fb0ed28
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc37fb0ed28
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc37fb0ed28
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc37fb0ed28
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
❌ Test recipe publishing failed

radius-functional-tests · 2024-08-21T20:31:29Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`53f6469`
Unique ID	funca22c57cf8b
Image tag	pr-funca22c57cf8b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca22c57cf8b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca22c57cf8b
controller test image location: ghcr.io/radius-project/dev/controller:pr-funca22c57cf8b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca22c57cf8b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

pkg/corerp/api/v20231001preview/container_conversion.go

pkg/corerp/api/v20231001preview/container_conversion_test.go

pkg/corerp/renderers/container/render.go

radius-functional-tests · 2024-08-22T00:09:44Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`68c8308`
Unique ID	funca2ace6278d
Image tag	pr-funca2ace6278d

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca2ace6278d
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca2ace6278d
controller test image location: ghcr.io/radius-project/dev/controller:pr-funca2ace6278d
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca2ace6278d
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

pkg/corerp/renderers/container/render_test.go

...tion/applications/resource-manager/Applications.Core/preview/2023-10-01-preview/openapi.json

...-portable/datastoresrp/noncloud/resources/testdata/datastoresrp-resources-redis-manual.bicep

radius-functional-tests · 2024-08-22T06:02:42Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`0919594`
Unique ID	funcd288ae6224
Image tag	pr-funcd288ae6224

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd288ae6224
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd288ae6224
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd288ae6224
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd288ae6224
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Initial PR for design doc in support of radius-project/radius#7744 addressing radius-project/radius#5520 --------- Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny · 2024-09-01T15:20:46Z

not sure how that happened

radius-functional-tests · 2024-09-03T16:13:10Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`cb7775b`
Unique ID	func15b1de24be
Image tag	pr-func15b1de24be

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func15b1de24be
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func15b1de24be
controller test image location: ghcr.io/radius-project/dev/controller:pr-func15b1de24be
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func15b1de24be
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

radius-functional-tests · 2024-09-03T18:22:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`9ebc7ab`
Unique ID	func39e72d10a7
Image tag	pr-func39e72d10a7

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func39e72d10a7
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func39e72d10a7
controller test image location: ghcr.io/radius-project/dev/controller:pr-func39e72d10a7
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func39e72d10a7
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

kachawla

Thanks for addressing the comments!

Initial PR for design doc in support of radius-project/radius#7744 addressing radius-project/radius#5520 --------- Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

superbeeny requested review from a team as code owners July 18, 2024 18:17

superbeeny temporarily deployed to functional-tests July 18, 2024 18:17 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests July 18, 2024 18:27 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests July 18, 2024 18:49 — with GitHub Actions Inactive

superbeeny mentioned this pull request Jul 18, 2024

REQUEST: New membership for @superbeeny radius-project/community#41

Closed

superbeeny force-pushed the superbeeny/secretstores branch from 5f240b8 to 910fdde Compare July 18, 2024 19:03

superbeeny temporarily deployed to functional-tests July 18, 2024 19:04 — with GitHub Actions Inactive

rynowak reviewed Jul 19, 2024

View reviewed changes

typespec/Applications.Core/containers.tsp Show resolved Hide resolved

rynowak reviewed Jul 19, 2024

View reviewed changes

pkg/corerp/api/v20231001preview/container_conversion.go Outdated Show resolved Hide resolved

rynowak reviewed Jul 19, 2024

View reviewed changes

pkg/corerp/renderers/container/render.go Outdated Show resolved Hide resolved

rynowak reviewed Jul 19, 2024

View reviewed changes

pkg/corerp/renderers/container/render_test.go Show resolved Hide resolved

ytimocin reviewed Jul 19, 2024

View reviewed changes

lakshmimsft reviewed Jul 20, 2024

View reviewed changes

pkg/corerp/api/v20231001preview/container_conversion.go Outdated Show resolved Hide resolved

lakshmimsft reviewed Jul 20, 2024

View reviewed changes

pkg/corerp/api/v20231001preview/container_conversion.go Outdated Show resolved Hide resolved

lakshmimsft reviewed Jul 22, 2024

View reviewed changes

typespec/Applications.Core/containers.tsp Outdated Show resolved Hide resolved

ytimocin reviewed Aug 2, 2024

View reviewed changes

pkg/corerp/api/v20231001preview/container_conversion.go Outdated Show resolved Hide resolved

pkg/corerp/datamodel/container.go Show resolved Hide resolved

willtsai mentioned this pull request Aug 5, 2024

Feature specs: Applications.Core/secretStores extended use cases radius-project/design-notes#57

Open

superbeeny force-pushed the superbeeny/secretstores branch from e0b647e to 52fb121 Compare August 14, 2024 17:47

kachawla temporarily deployed to functional-tests August 15, 2024 17:31 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests August 21, 2024 20:30 — with GitHub Actions Inactive

kachawla reviewed Aug 22, 2024

View reviewed changes

superbeeny temporarily deployed to functional-tests August 22, 2024 00:08 — with GitHub Actions Inactive

kachawla reviewed Aug 22, 2024

View reviewed changes

pkg/corerp/renderers/container/render_test.go Show resolved Hide resolved

kachawla reviewed Aug 22, 2024

View reviewed changes

...tion/applications/resource-manager/Applications.Core/preview/2023-10-01-preview/openapi.json Show resolved Hide resolved

kachawla reviewed Aug 22, 2024

View reviewed changes

...-portable/datastoresrp/noncloud/resources/testdata/datastoresrp-resources-redis-manual.bicep Outdated Show resolved Hide resolved

superbeeny temporarily deployed to functional-tests August 22, 2024 06:01 — with GitHub Actions Inactive

willtsai mentioned this pull request Aug 30, 2024

Fixes #1205 - updating bicep files for new container environment vari… radius-project/docs#1207

Merged

6 tasks

superbeeny closed this Sep 1, 2024

superbeeny force-pushed the superbeeny/secretstores branch from 0919594 to 7232cc6 Compare September 1, 2024 15:10

superbeeny reopened this Sep 1, 2024

superbeeny temporarily deployed to functional-tests September 3, 2024 16:11 — with GitHub Actions Inactive

superbeeny force-pushed the superbeeny/secretstores branch from 1d9cbd7 to 4c3613c Compare September 3, 2024 16:43

adding secrets as environment variables

f2ffaa6

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny force-pushed the superbeeny/secretstores branch from 4c3613c to f2ffaa6 Compare September 3, 2024 17:20

superbeeny added 2 commits September 3, 2024 13:20

Merge branch 'main' into superbeeny/secretstores

f85829d

regenerating files

9ebc7ab

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny temporarily deployed to functional-tests September 3, 2024 18:21 — with GitHub Actions Inactive

rynowak approved these changes Sep 3, 2024

View reviewed changes

rynowak merged commit 3ddb61e into radius-project:main Sep 3, 2024
29 checks passed

kachawla approved these changes Sep 3, 2024

View reviewed changes

willtsai mentioned this pull request Sep 19, 2024

Support SecretStore in container resource (Native Radius Way) for k8s Secrets. #7051

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Kubernetes native secrets to secret stores #7744

Adding Kubernetes native secrets to secret stores #7744

superbeeny commented Jul 18, 2024

radius-functional-tests bot commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

radius-functional-tests bot commented Jul 18, 2024 •

edited

Loading

radius-functional-tests bot commented Jul 18, 2024 •

edited

Loading

radius-functional-tests bot commented Jul 18, 2024 •

edited

Loading

rynowak commented Jul 19, 2024

ytimocin left a comment

superbeeny commented Jul 19, 2024

superbeeny commented Jul 19, 2024

radius-functional-tests bot commented Aug 15, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 15, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 21, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 22, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 22, 2024 •

edited

Loading

superbeeny commented Sep 1, 2024

radius-functional-tests bot commented Sep 3, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 3, 2024 •

edited

Loading

kachawla left a comment

Adding Kubernetes native secrets to secret stores #7744

Adding Kubernetes native secrets to secret stores #7744

Conversation

superbeeny commented Jul 18, 2024

Description

Type of change

radius-functional-tests bot commented Jul 18, 2024 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Jul 18, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Jul 18, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jul 18, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jul 18, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak commented Jul 19, 2024

ytimocin left a comment

Choose a reason for hiding this comment

superbeeny commented Jul 19, 2024

superbeeny commented Jul 19, 2024

radius-functional-tests bot commented Aug 15, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Aug 15, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Aug 21, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Aug 22, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Aug 22, 2024 • edited Loading

Radius functional test overview

Test Status

superbeeny commented Sep 1, 2024

radius-functional-tests bot commented Sep 3, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Sep 3, 2024 • edited Loading

Radius functional test overview

Test Status

kachawla left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

radius-functional-tests bot commented Jul 18, 2024 •

edited

Loading

radius-functional-tests bot commented Jul 18, 2024 •

edited

Loading

radius-functional-tests bot commented Jul 18, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 15, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 15, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 21, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 22, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 22, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 3, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 3, 2024 •

edited

Loading