Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate pulling the RC tagged version of bicep during release verification #6897

Open
sk593 opened this issue Dec 1, 2023 · 4 comments
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. release-improvements Issues faced during release process triaged This issue has been reviewed and triaged

Comments

@sk593
Copy link
Contributor

sk593 commented Dec 1, 2023

Engineering Improvement

Area for Improvement (required)

This issue is to investigate pulling the RC tagged version of bicep during the release verification workflow or somewhere in the release process.

Observed behavior (required)

We ran into an issue with the 0.27 release process where the samples verification workflow failed while downloading bicep but was not caught in any other workflows. This is because the samples repo is the only place that tests pulling an RC tagged version of bicep here: https://github.com/radius-project/samples/blob/a420f9e02151240905ceb63c0da881f268d5d527/.github/workflows/test.yaml#L189

We found that the RC tagged version of bicep was not getting uploaded and had to create a fix during the 0.27 release process.

Desired behavior (required)

Ideally, we would have caught this download failure earlier in the release process, before we ran the samples verification workflow. We have a release verification workflow that runs once we create an RC version of the release, but there's no step to test bicep downloads, see here: https://github.com/radius-project/radius/blob/main/.github/scripts/release-verification.sh

Proposed Fix (optional)

We'd like to investigate if we can test bicep downloads earlier in the release process so that we catch possible errors sooner.

System information

rad Version (required)

Operating system (required)

Additional context

AB#10635

@sk593 sk593 added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Dec 1, 2023
@radius-triage-bot
Copy link

👋 @sk593 Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@shalabhms shalabhms added the triaged This issue has been reviewed and triaged label Dec 7, 2023
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@shalabhms shalabhms added the important This item is a high priority Issue we intend to address as soon as possible label Dec 7, 2023
@radius-triage-bot
Copy link

We've prioritized work on this issue. Please subscribe to this issue for notifications, we'll provide updates as we make progress.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@kachawla kachawla added the release-improvements Issues faced during release process label Feb 8, 2024
@nicolejms
Copy link
Contributor

Removing important since we will need to revisit how we decide what version of the public bicep release we will be using each release.

@nicolejms nicolejms removed the important This item is a high priority Issue we intend to address as soon as possible label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. release-improvements Issues faced during release process triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

4 participants